Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40713
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.178 cause and error)
Message-ID: <48DD3FAE.8050807@sci.fi>
Date: Fri, 26 Sep 2008 23:01:50 +0300
Reply-To: jani.taskinen@iki.fi
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Lukas Kahwe Smith <mls@pooteeweet.org>
CC: Michael Wallner <mike@php.net>, internals@lists.php.net
References: <03.52.27158.9D5A2D84@pb1.pair.com> <DE46E177-EF36-4B75-AC14-5AFDA84A84DD@pooteeweet.org> <1D.C1.19781.C63BCD84@pb1.pair.com> <94232D93-D448-4403-A81D-2EB5904AAB8D@pooteeweet.org>
In-Reply-To: <94232D93-D448-4403-A81D-2EB5904AAB8D@pooteeweet.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [Fwd: [PATCH] Backport of HEADs output API]
From: jani.taskinen@sci.fi (Jani Taskinen)

Lukas Kahwe Smith wrote:
> 
> On 26.09.2008, at 12:04, Michael Wallner wrote:
> 
>> Lukas Kahwe Smith wrote:
>>> well the question is does it fix some real world bugs? this late in the
>>> game i would not want to include these changes if they "just" add
>>> features ..
>>
>> Huh? :)  The question to me is, why did you ask me to do it, when
>> you're not sure what it's about? Not to be anally at all... ;)
> 
> I guess we cleared up the misunderstanding on IRC.
> 
>> The greatest plus to me are:
>>     - getting rid of monolithic php_end_ob_buffer()
>>     - getting rid of output handler specific code in SAPI.c
>>     - being able to hook from the running output handler to change 
>> it's behavior
>>     - being able to clearly configure conflicts and reverse conflicts 
>> between output handlers
> 
> 
> These are all convincing arguments to have done this earlier. But 
> Johannes and I are a bit worried, that this code did not see that much 
> testing since it was checked in to HEAD quite a while ago. And seeing 
> that the backport is mainly cleanup and not bug fixing, we are a bit 
> worried about the risk this backport has (not necessarily in it 
> introducing bugs, but more about BC issues here and there). Especially 
> since it seems that you are the only one who actively looks after output 
> buffering .. (Johannes actually asked to have this stuff in PHP 5.3 
> months ago, but you were a  bit MIA back then .. and nobody else showed 
> interest).
> 
> So unless you can take our worries away in terms of BC issues, I guess 
> we would prefer to leave this patch out of PHP 5.3.
> Sorry about the misunderstanding and the work you put into producing 
> this patch.

The patch fixes several output buffer bugs. Those alone are enough to 
allow this getting in PHP_5_3 and really get TESTED too.

You're releasing alphas still, so something like this is not really that 
bad..

--Jani