Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40692
Return-Path: <crrodriguez@suse.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 78386 invoked from network); 25 Sep 2008 21:59:53 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 25 Sep 2008 21:59:53 -0000
Authentication-Results: pb1.pair.com smtp.mail=crrodriguez@suse.de; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=crrodriguez@suse.de; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain suse.de from 195.135.220.15 cause and error)
X-PHP-List-Original-Sender: crrodriguez@suse.de
X-Host-Fingerprint: 195.135.220.15 cantor2.suse.de Linux 2.4/2.6
Received: from [195.135.220.15] ([195.135.220.15:59775] helo=mx2.suse.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 80/E9-19781-4D90CD84 for <internals@lists.php.net>; Thu, 25 Sep 2008 17:59:50 -0400
Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx2.suse.de (Postfix) with ESMTP id 47D0745A88;
	Thu, 25 Sep 2008 23:59:46 +0200 (CEST)
Message-ID: <48DC09CB.4010606@suse.de>
Date: Thu, 25 Sep 2008 17:59:39 -0400
Organization: Platform/OpenSUSE - Core Services, SUSE LINUX Products GmbH,
 Research & Development 
User-Agent: Thunderbird 2.0.0.16 (X11/20080720)
MIME-Version: 1.0
To: Scott MacVicar <scott@macvicar.net>
Cc: PHP Developers Mailing List <internals@lists.php.net>
References: <B4142BDF-7319-4AB4-8274-376FAEE822CC@macvicar.net>
In-Reply-To: <B4142BDF-7319-4AB4-8274-376FAEE822CC@macvicar.net>
X-Enigmail-Version: 0.95.7
OpenPGP: id=85898BD3
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigE02D45C2991CCC19598B94CA"
Subject: Re: [PHP-DEV] OpenSSL random pseudo bytes
From: crrodriguez@suse.de (=?UTF-8?B?Q3Jpc3RpYW4gUm9kcsOtZ3Vleg==?=)

--------------enigE02D45C2991CCC19598B94CA
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Scott MacVicar escribi=C3=B3:
> Hi All,
>=20
> Attached and uploaded [1] is a patch to add the OpenSSL random pseudo
> byte function, at the moment it will return FALSE if the bytes aren't
> considered cryptographically strong, I am however considering making
> this parameter controlled.
>=20
> Any objections to me applying this to 5.3?
>=20
> Scott
> --=20
> [1] - http://whisky.macvicar.net/patches/openssl_prg.patch.txt
>=20
>=20

What is the status of this ? I see nothing that can break with this
patch, but I would suggest the function to take the second argument by
value instead of by reference, valid code like

<?php

$activation_code =3D md5(openssl_random_pseudo_bytes(128, true));

?>

causes a Fatal error: Only variables can be passed by reference...





--=20
"A computer is like an Old Testament god, with a lot of rules and no
mercy. "

Cristian Rodr=C3=ADguez R.
Platform/OpenSUSE - Core Services
SUSE LINUX Products GmbH
Research & Development
http://www.opensuse.org/



--------------enigE02D45C2991CCC19598B94CA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkjcCc4ACgkQhbiInYWJi9N31ACgkPEAgWX6bMZvaeYaaCyL6PGt
xjcAnjL+c7bZDt24rVhX091IGMi4kLMc
=WEq2
-----END PGP SIGNATURE-----

--------------enigE02D45C2991CCC19598B94CA--