Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40616
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.14 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type;
        b=QpvNABnbby7zKrz/K/VILGntA19jVx+DVjvSbkeshWlQuL3YeMVCWDnN97Ul9G9EoW
         scZUmOflMjZnPjPM1BCC4/WyGYbIqe+9EMP83vlPRQawY0zhkacVMCP/GkmzpX6bq66c
         z18NEeAlvSTdWkHo6LIpJlw2Z8aE2XrPkqev4=
Message-ID: <c6979f520809222202g77d19342gf59a7b0b254b4f04@mail.gmail.com>
Date: Mon, 22 Sep 2008 23:02:11 -0600
To: internals@lists.php.net
MIME-Version: 1.0
Content-Type: multipart/mixed; 
	boundary="----=_Part_86842_28128507.1222146131043"
Subject: Proposed Patch: Fix compiler warning in Zend/zend_execute.c
From: ilia.cheishvili@gmail.com ("Ilia Cheishvili")

------=_Part_86842_28128507.1222146131043
Content-Type: multipart/alternative; 
	boundary="----=_Part_86843_15501375.1222146131043"

------=_Part_86843_15501375.1222146131043
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi all,

My name is Ilia--I figured that since this is my first patch to the PHP
core, I should refrain from submitting a massive patch and keep it simple.
The patch that I have attached fixes a simple compiler warning within
Zend/zend_execute.c.

The compiler was complaining about comparing signed and unsigned integers.
What I did was wrap the whole block in an if statement that first ensures
that the signed integer in the comparison is greater than or equal to 0 and
then casts it to unsigned and actually does the comparison.  Since the
actual comparison logic is checking to see that an unsigned integer is
larger than the one I am casting, this is all safe.

Also, the entire test suite runs fine and the output is unchanged.  All in
all, I am confident with it.

After having used PHP for so many years, I'm really excited about finally
having found the time to apply my C knowledge and actually start
contributing back to the project :)

Thanks!

Ilia

------=_Part_86843_15501375.1222146131043
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<div dir="ltr">Hi all,<br><br>My name is Ilia--I figured that since this is my first patch to the PHP core, I should refrain from submitting a massive patch and keep it simple.&nbsp; The patch that I have attached fixes a simple compiler warning within Zend/zend_execute.c.<br>
<br>The compiler was complaining about comparing signed and unsigned integers.&nbsp; What I did was wrap the whole block in an if statement that first ensures that the signed integer in the comparison is greater than or equal to 0 and then casts it to unsigned and actually does the comparison.&nbsp; Since the actual comparison logic is checking to see that an unsigned integer is larger than the one I am casting, this is all safe.<br>
<br>Also, the entire test suite runs fine and the output is unchanged.&nbsp; All in all, I am confident with it.<br><br>After having used PHP for so many years, I&#39;m really excited about finally having found the time to apply my C knowledge and actually start contributing back to the project :)<br>
<br>Thanks!<br><br>Ilia<br></div>

------=_Part_86843_15501375.1222146131043--

------=_Part_86842_28128507.1222146131043
Content-Type: text/plain; name=zend_execute.c.diff.txt
Content-Transfer-Encoding: base64
X-Attachment-Id: f_flg1vw4l0
Content-Disposition: attachment; filename=zend_execute.c.diff.txt

SW5kZXg6IHplbmRfZXhlY3V0ZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9yZXBvc2l0b3J5L1pl
bmRFbmdpbmUyL3plbmRfZXhlY3V0ZS5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjcxNi4yLjEy
LjIuMjQuMi4zNgpkaWZmIC11IC1iIC1yMS43MTYuMi4xMi4yLjI0LjIuMzYgemVuZF9leGVjdXRl
LmMKLS0tIHplbmRfZXhlY3V0ZS5jCTE1IEF1ZyAyMDA4IDE5OjQ3OjIzIC0wMDAwCTEuNzE2LjIu
MTIuMi4yNC4yLjM2CisrKyB6ZW5kX2V4ZWN1dGUuYwkyMyBTZXAgMjAwOCAwNDoyMzoyNCAtMDAw
MApAQCAtNjI2LDcgKzYyNiw5IEBACiAJCQlyZXR1cm4gMDsKIAkJfQogCi0JCWlmIChULT5zdHJf
b2Zmc2V0Lm9mZnNldCA+PSBaX1NUUkxFTl9QKFQtPnN0cl9vZmZzZXQuc3RyKSkgeworCQlpZiAo
Wl9TVFJMRU5fUChULT5zdHJfb2Zmc2V0LnN0cikgPj0gMCkKKwkJeworCQkJaWYgKFQtPnN0cl9v
ZmZzZXQub2Zmc2V0ID49ICh1bnNpZ25lZCBpbnQpIFpfU1RSTEVOX1AoVC0+c3RyX29mZnNldC5z
dHIpKSB7CiAJCQlaX1NUUlZBTF9QKFQtPnN0cl9vZmZzZXQuc3RyKSA9IChjaGFyICopIGVyZWFs
bG9jKFpfU1RSVkFMX1AoVC0+c3RyX29mZnNldC5zdHIpLCBULT5zdHJfb2Zmc2V0Lm9mZnNldCsx
KzEpOwogCQkJbWVtc2V0KFpfU1RSVkFMX1AoVC0+c3RyX29mZnNldC5zdHIpICsgWl9TVFJMRU5f
UChULT5zdHJfb2Zmc2V0LnN0ciksCiAJCQkgICAgICAgJyAnLApAQCAtNjM0LDYgKzYzNiw3IEBA
CiAJCQlaX1NUUlZBTF9QKFQtPnN0cl9vZmZzZXQuc3RyKVtULT5zdHJfb2Zmc2V0Lm9mZnNldCsx
XSA9IDA7CiAJCQlaX1NUUkxFTl9QKFQtPnN0cl9vZmZzZXQuc3RyKSA9IFQtPnN0cl9vZmZzZXQu
b2Zmc2V0KzE7CiAJCX0KKwkJfQogCiAJCWlmIChaX1RZUEVfUCh2YWx1ZSkgIT0gSVNfU1RSSU5H
KSB7CiAJCQl6dmFsIHRtcCA9ICp2YWx1ZTsK
------=_Part_86842_28128507.1222146131043--