Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:40501 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54833 invoked from network); 13 Sep 2008 09:30:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Sep 2008 09:30:54 -0000 Authentication-Results: pb1.pair.com header.from=mls@pooteeweet.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=mls@pooteeweet.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error) X-PHP-List-Original-Sender: mls@pooteeweet.org X-Host-Fingerprint: 88.198.8.16 bigtime.backendmedia.com Linux 2.6 Received: from [88.198.8.16] ([88.198.8.16:59360] helo=bigtime.backendmedia.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AA/E3-24472-E488BC84 for ; Sat, 13 Sep 2008 05:30:54 -0400 Received: from localhost (unknown [127.0.0.1]) by bigtime.backendmedia.com (Postfix) with ESMTP id 1260B414400B; Sat, 13 Sep 2008 09:32:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at backendmedia.com Received: from bigtime.backendmedia.com ([127.0.0.1]) by localhost (bigtime.backendmedia.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id msrWT4DxMO8V; Sat, 13 Sep 2008 11:32:45 +0200 (CEST) Received: from [172.26.31.232] (tmo-102-1.customers.d1-online.com [80.187.102.1]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mls@pooteeweet.org) by bigtime.backendmedia.com (Postfix) with ESMTP id 320CF4144009; Sat, 13 Sep 2008 11:32:40 +0200 (CEST) Cc: "PHP Internals List" Message-ID: <756091FC-32B4-4B38-BACA-8C1288D782FA@pooteeweet.org> To: Jordi Boggiano In-Reply-To: <4bcbf4710809060242o7116d6bcldd69db2d06dc8b5a@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v928.1) Date: Sat, 13 Sep 2008 11:30:14 +0200 References: <20080904190717.aaz97tz688oogc4c@horde.chinstrap.eu> <48C0488C.9090209@sci.fi> <48C04E6A.2080909@zend.com> <48C1A51D.5030803@zend.com> <48C1C89D.2050603@zend.com> <48C1CB86.7030600@macvicar.net> <4bcbf4710809060242o7116d6bcldd69db2d06dc8b5a@mail.gmail.com> X-Mailer: Apple Mail (2.928.1) Subject: Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3 From: mls@pooteeweet.org (Lukas Kahwe Smith) On 06.09.2008, at 11:42, Jordi Boggiano wrote: > On Sat, Sep 6, 2008 at 2:15 AM, Scott MacVicar > wrote: >> Stanislav Malyshev wrote: >>> No, the main argument is that it would break people's configs, and >>> for >>> no good reason at all (nobody really needs \n's in their paths). >> >> This code is used in parse_ini_file() where it is possible that >> escapes >> would be used legitimately, it's not all about paths. > > This means that not only php.ini will fail - although that is indeed > easy to notice - but also any application using ini files might break > in a much less obvious manner, right ? It's something that might need > to be taken into account. Seems to me like we should consider delaying this fix to 6.0. I agree with Pierre that its probably not a good idea to introduce special handling here and there. As for the error handling, Pierre mentioned that Jani did some tweaks there too. Could someone explain to me what kind of error handling is out into place? If we throw a nice error message for all cases where someone is using \t, \n etc incorrectly inside a php.ini, I think it will not be such a big deal at upgrade time. But still it seems like something we might want to hold off until 6.0, considering that the bug that was fixed did not affect that many users (just a guess). regards, Lukas Kahwe Smith mls@pooteeweet.org