Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40415
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.157 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=kFrSAEz511JqVDk+zdbhuA9+la6cmUlDpRPvH4sXkrfeBb8RUEwDDcJfmra1xpwPrA
         lgKRPksP1hBWMzxnbmxkuhYgFwmqC54ypTAMgmfne4sMjrGbS+7FbB/tAaXzV9BG40Ly
         mSnf83JUHJkhbFKuZC+txGQHPabKUF+5mr0P0=
To: Christian Schneider <cschneid@cschneid.com>
Date: Tue, 9 Sep 2008 17:59:39 +0200
User-Agent: KMail/1.10.0 (Linux/2.6.26-1-amd64; KDE/4.1.0; x86_64; ; )
Cc: internals@lists.php.net,
 Alexey Zakhlestin <indeyets@gmail.com>
References: <cd5680a20809090539j5af439d8ve5ac8c0003f1ea66@mail.gmail.com> <200809091651.55770.arnaud.lb@gmail.com> <48C697DA.2080003@cschneid.com>
In-Reply-To: <48C697DA.2080003@cschneid.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200809091759.39808.arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] Opinion needed (bug #45928)
From: arnaud.lb@gmail.com (Arnaud Le Blanc)

Hi,

On Tuesday 09 September 2008 17:35:54 Christian Schneider wrote:
> Arnaud Le Blanc wrote:
> > The following may (no MacOS X to test) fix the problem by returning 0 from 
> > zend_stream_fsize() when the file descriptor is not a regular file:
> > http://arnaud.lb.s3.amazonaws.com/45928.patch
> 
> Your patch:
> +#ifdef S_ISREG
> +		if (!S_ISREG(buf.st_mode)) {
> +			return 0;
> +		}
> +#endif
> might prevent mmap-ing symbolically linked files, I'll do a quick test
> when I'm at home.

No, fstat() will resolve the link and stat the file the link points to. And I 
believe script paths are fully resolved before being opened.

Anyway, given the fstat() Linux man page, its a bug to return st_size when the 
file is not a regular file.

> Not sure if we should also check for symbolic links (and what they point
> to) or if that's overkill because the performance penalty is small
> enough anyway.
> 
> Anyone from the core developers got an opinion here?
> 
> - Chris
> 

Regards,

Arnaud