Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40386
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.44.30 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type
         :content-transfer-encoding:content-disposition;
        b=tQOQzTPAhPVxzk22nSX77CGnmxUuSrMWcFW0UHizPUHIe3zvveO9fjhA5DqhA9Ym8F
         5AqpEE7RXiuW4lzl2ntWxnAOeVQhA7Na3moGNMlgbV5o5NqYcBX1J1eL2q79/tHDgr1J
         saZAzK8QM57ILXSem9rj/QWTHxzzxi/864ars=
Message-ID: <bcb7aa500809081750x79e3ef9eyc3ea93ccc8a55adf@mail.gmail.com>
Date: Mon, 8 Sep 2008 21:50:30 -0300
To: "PHP Internals" <internals@lists.php.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Subject: Suggestion to increase the max_input_nesting_level
From: guilhermeblanco@gmail.com ("Guilherme Blanco")

Hi ML,


Short version: Increase the default max_input_nesting_level from 100
to something > 150.
Extended version:

I am working on a Compiler written for PHP. Before you criticize me,
let me explain the entire situation.
I work for Doctrine project. Currently we're refactoring the DQL
(Doctrine Query Language) compiler, which processes our SQL-similar
language and convert it into a valid SQL statement for the driver
being used.
If you want a comparative, our approach is inspired in known OQL, like
JPQL of Hibernate in Java.
One example:

SELECT u FROM User u

It'll be converted into something like:

SELECT u.id AS u__id, u.name AS u__name, u.passwd AS u_passwd, u.email
AS u__email FROM user u

Please notice this is a very simple example, but highlights how does it work.

Currently I'm working on the compiler, which has this BNF:
http://trac.doctrine-project.org/browser/trunk/query-language.txt
I've done a lot of optimizations to be able to not touch the default
nesting input level, but doing that I added a lot of restrictions that
now are my bottlenecks.
With all these optimizations, it currently reaches ~70.
I made a lot of tests and the queries usually reaches 103... some
complex ones reached ~140 nested calls.
I know PHP was not structured to build compilers, and also I know this
property can be overrided (many users do not have access to it), but I
think for this situation it worth a consideration.
Also, it's not a simple change for only one user, since our code usage
is very large.

My suggestion is to increase to something like 180, available since PHP 5.3.
I'd like to know your thoughts about this subject.

Thanks in advance,


Best regards,

-- 
Guilherme Blanco - Web Developer
CBC - Certified Bindows Consultant
Cell Phone: +55 (16) 9166-6902
MSN: guilhermeblanco@hotmail.com
URL: http://blog.bisna.com
Rio de Janeiro - RJ/Brazil