Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40345
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.14 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=oEPEx0sfRLXv2WYcxFugpZqrvXizQLDBUUqCRKUy1PKq6j70ZS9B7WnOpSz7sRpY7D
         zYvuVd+pBeGjK7qpX1SIp0D9EzefvGiBcywxaVBKeoRQhGNBhXPbIeHW8wTUlukTRpGf
         7ENdGNooURgyuLPcLNTVgActAFJvzbIInArkM=
Message-ID: <cd5680a20809080739q11f53e93r9ec986eee859ca11@mail.gmail.com>
Date: Mon, 8 Sep 2008 18:39:48 +0400
To: "Christian Schneider" <cschneid@cschneid.com>
Cc: jani.taskinen@iki.fi, "internals Mailing List" <internals@lists.php.net>
In-Reply-To: <48C528D9.3030608@cschneid.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <48C3BC03.7060004@sci.fi> <48C528D9.3030608@cschneid.com>
Subject: Re: [PHP-DEV] Re: Critical bugs to fix before ANY release
From: indeyets@gmail.com ("Alexey Zakhlestin")

On Mon, Sep 8, 2008 at 5:30 PM, Christian Schneider
<cschneid@cschneid.com> wrote:
> I had a quick look at bug
>        http://bugs.php.net/bug.php?id=45928
> and found the problem to be in Zend/zend_stream.c function
> zend_stream_fsize(): It uses fstat() to determine the filesize which on
> MacOS X for pipes returns either 0 (my interpretation: no data from the
> pipe ready yet) or a number up to 16384 (my interpretation: data from
> the pipe ready but the maximum buffer size is 16k).

I believe your interpretation is correct.
it returns amount of data, which is available on pipe, so we can
request that amount immediately, and later check if some more is
available.

> I see several solutions but I'm not sure which is the desired one:
> - return 0 (size unknown) if the file is a pipe (or socket, ...)
> - return 0 if the file is not a regular file (or symlink, dir?)
> - look into a way of determining EOF reached

well, I guess there is no way to get "filesize" of piped data, because
it is completely dynamic.

at the lowest level, libc's read() returns 0 in case of EOF and -1 in
case of error.
that's the way to distinguish them.

-- 
Alexey Zakhlestin
http://blog.milkfarmsoft.com/