Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:40295 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77311 invoked from network); 6 Sep 2008 00:15:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Sep 2008 00:15:23 -0000 Authentication-Results: pb1.pair.com header.from=scott@macvicar.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=scott@macvicar.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain macvicar.net from 193.227.246.108 cause and error) X-PHP-List-Original-Sender: scott@macvicar.net X-Host-Fingerprint: 193.227.246.108 ip246-108-v193.static.x-ip.net Received: from [193.227.246.108] ([193.227.246.108:58796] helo=lovelace.midden.org.uk) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CA/A3-56363-99BC1C84 for ; Fri, 05 Sep 2008 20:15:22 -0400 Received: from macvicar.demon.co.uk ([80.177.111.173] helo=[192.168.1.102]) by lovelace.midden.org.uk with esmtp (Exim 4.69) (envelope-from ) id 1KblSM-0002IH-Oj; Sat, 06 Sep 2008 01:15:17 +0100 Message-ID: <48C1CB86.7030600@macvicar.net> Date: Sat, 06 Sep 2008 01:15:02 +0100 User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Stanislav Malyshev CC: Pierre Joye , PHP Internals List References: <20080904190717.aaz97tz688oogc4c@horde.chinstrap.eu> <48C0488C.9090209@sci.fi> <48C04E6A.2080909@zend.com> <48C1A51D.5030803@zend.com> <48C1C89D.2050603@zend.com> In-Reply-To: <48C1C89D.2050603@zend.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -3.2 X-Spam_Report: Spam detection software, running on the system "lovelace.midden.org.uk", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stanislav Malyshev wrote: > Hi! > >> That's exactly why I am reluctant to change what Jani did. It is >> easier to deal with this minor breakage in 5.3.0 and then have a >> consistent and clean configuration system. Continuing to add some >> exceptions while hoping that "no weird things" are used is a bad idea > > Do you see any problem with my patch? Any weird things? > >> Jani even suggested to add _fatal_ error. The lack of error messages >> was one of the main arguments against this feature. > > No, the main argument is that it would break people's configs, and for > no good reason at all (nobody really needs \n's in their paths). [...] Content analysis details: (-3.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.6 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] -0.6 AWL AWL: From: address is in the auto white-list Subject: Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3 From: scott@macvicar.net (Scott MacVicar) Stanislav Malyshev wrote: > Hi! > >> That's exactly why I am reluctant to change what Jani did. It is >> easier to deal with this minor breakage in 5.3.0 and then have a >> consistent and clean configuration system. Continuing to add some >> exceptions while hoping that "no weird things" are used is a bad idea > > Do you see any problem with my patch? Any weird things? > >> Jani even suggested to add _fatal_ error. The lack of error messages >> was one of the main arguments against this feature. > > No, the main argument is that it would break people's configs, and for > no good reason at all (nobody really needs \n's in their paths). This code is used in parse_ini_file() where it is possible that escapes would be used legitimately, it's not all about paths. Scott