Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40293
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.234 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=xPSdwmSjOpAdnaa6URUOxu0hazAb/N3goAuvWdUvlelvFA4NR4/Yu4oWN1VEFPzyLH
         aAt+t0Eiizkb80DALw1zKhRGICkR+BXpUN/YOHk7zBPiSGFy+8Ypgv4jKtiqqAfX1f9W
         fEJW5kG3zmN7rSdlaifkMm0uliA4aDBSWq8wc=
Message-ID: <fe05d1540809051658g4f29716cy8257af301d1aa535@mail.gmail.com>
Date: Sat, 6 Sep 2008 01:58:39 +0200
To: "Stanislav Malyshev" <stas@zend.com>
Cc: "PHP Internals List" <internals@lists.php.net>
In-Reply-To: <48C1A51D.5030803@zend.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080904190717.aaz97tz688oogc4c@horde.chinstrap.eu>
	 <48C0488C.9090209@sci.fi> <48C04E6A.2080909@zend.com>
	 <48C1A51D.5030803@zend.com>
Subject: Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3
From: pierre.php@gmail.com ("Pierre Joye")

hi,

On Fri, Sep 5, 2008 at 11:31 PM, Stanislav Malyshev <stas@zend.com> wrote:
> Hi!
>
> Attached is the patch that does the following for php.ini parser:
> 1. \{LETTER} is literal inside "" now, whatever the letter is
> 2. \" is " inside "", with exception of:
> 3. foo="bar\"{NEWLINE} is parsed as bar\ - i.e. \ is allowed before closing
> " but only if the line ends there (otherwise it's impossible to know what
> the intent was).
>
> That should make Windows paths work just fine (unless you have some really
> weird ones that I didn't think about) with double quotes.

That's exactly why I am reluctant to change what Jani did. It is
easier to deal with this minor breakage in 5.3.0 and then have a
consistent and clean configuration system. Continuing to add some
exceptions while hoping that "no weird things" are used is a bad idea
as well. There is a kind of breakage, but it is obvious and will be
directly seen as either the include_path will be incomplete (app
fails), an extension will be not be loaded, etc.

Jani even suggested to add _fatal_ error. The lack of error messages
was one of the main arguments against this feature.

-- 
Pierre

http://blog.thepimp.net | http://www.libgd.org