Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40281
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.178 cause and error)
Message-ID: <48C0EB92.40504@sci.fi>
Date: Fri, 05 Sep 2008 11:19:30 +0300
Reply-To: jani.taskinen@iki.fi
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Hannes Magnusson <hannes.magnusson@gmail.com>
CC: jani.taskinen@iki.fi, =?ISO-8859-1?Q?Johannes_Schl=FCter?=
 <johannes@php.net>, PHP Internals List <internals@lists.php.net>, 
 Pierre-Alain Joye <pajoye@php.net>
References: <20080904190717.aaz97tz688oogc4c@horde.chinstrap.eu>	 <48C0488C.9090209@sci.fi> <7f3ed2c30809050034mdaa38d1i7477a5be5cdd694c@mail.gmail.com>
In-Reply-To: <7f3ed2c30809050034mdaa38d1i7477a5be5cdd694c@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: ini-parsing, double quotes, windows in 5.3
From: jani.taskinen@sci.fi (Jani Taskinen)

Hannes Magnusson wrote:
> On Thu, Sep 4, 2008 at 22:43, Jani Taskinen <jani.taskinen@sci.fi> wrot=
e:
>> Johannes Schl=FCter kirjoitti:
>>> Hi,
>>>
>>> now that we have a publicly available alpha on Windows we get the fir=
st
>>> feedback from Windows users. Within quite short time we got two bug
>>> reports (#45992 #45994) about a change in the ini-parsing:
>>>
>>> With <=3D5.2 we allow
>>>
>>>  include_path =3D "c:\foo\bar\"
>> That SHOULD cause a syntax error of course. If it doesn't,
>> it's the bug to fix. Allowing \" was a bug that was fixed to begin wit=
h.
>> If that causes a syntax error, it's quite easy to catch and fix by peo=
ple
>> upgrading to 5.3..
>=20
> php.ini-recommended, 5.3:
> ;;;;;;;;;;;;;;;;;;;;;;;;;
> ; Paths and Directories ;
> ;;;;;;;;;;;;;;;;;;;;;;;;;
>=20
> ; UNIX: "/path1:/path2"
> ;include_path =3D ".:/php/includes"
> ;
> ; Windows: "\path1;\path2"
> ;include_path =3D ".;c:\php\includes"
>=20
>=20
> As you can see, Windows users are explicitly told to use foo\bar\
> inside double quotes.
> This has been like this for years and is also documented in the manual.=

>=20
> It looks to me that the old behavior was very intentional, logical or n=
ot.

Ini files are not documentation. And as / works also for winblows, that=20
should be used JUST for the sake of consistency anyway..

Anyway, the fix is quite easy: Only allow \" and no other escapes. And=20
doing "foo\" should cause a syntax error.

--Jani