Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40222
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.190 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=UETdl1hhFClwrkhrPg4QRUQFdqWi3VmEp0FlYcbA4dyCN1XKbUh2UMrxIuG3bToydQ
         msKxDYehf4s9goY6fnsgq8PZCMhKhszGn/nhLL5ZMJt8wUbhaN3Yj9CjKd8VDETr/3Wh
         MF128Z3LI3SJg2oY36q5wbY9F+3cvG1aopHYE=
To: Dmitry Stogov <dmitry@zend.com>
Date: Wed, 3 Sep 2008 00:30:47 +0200
User-Agent: KMail/1.10.0 (Linux/2.6.26-1-amd64; KDE/4.1.0; x86_64; ; )
Cc: jani.taskinen@iki.fi,
 Lukas Kahwe Smith <mls@pooteeweet.org>,
 Marcus Boerger <helly@php.net>,
 Stanislav Malyshev <stas@zend.com>,
 PHP Internals List <internals@lists.php.net>
References: <48BCFF84.9080801@zend.com> <48BD0A53.2030202@sci.fi> <48BD1226.5010902@zend.com>
In-Reply-To: <48BD1226.5010902@zend.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200809030030.48091.arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] BUG #45392
From: arnaud.lb@gmail.com (Arnaud Le Blanc)

Hi,

On Tuesday 02 September 2008 12:15:02 Dmitry Stogov wrote:
> 
> Jani Taskinen wrote:
> >>> Dmitry Stogov wrote:
> >>>> Hi,
> >>>>
> >>>> Attached is a proposed fix for http://bugs.php.net/bug.php?id=45392 for
> >>>> PHP_5_3. I don't know output buffering part very well, and I'm not
> >>>> completely sure about this fix, so please review it.
> >>>>
> >>>> The patch changes behavior of output buffering a bit. In case of fatal
> >>>> error all output buffers opened by ob_start() with zero (or omitted)
> >>>> chunk_size argument are discarded. The fix brakes two tests:
> >>>>
> >>>> Test session_module_name() function : variation
> >>>> [ext/session/tests/session_module_name_variation3.phpt]
> >>>> Test session_set_save_handler() function : error functionality
> >>>> [ext/session/tests/session_set_save_handler_error3.phpt]
> >>>>
> >>>> We need to make a decision about #45392.
> >>>>
> >>>> 1) Fix it with proposed (or similar) patch
> >>>>
> >>>> 2) Make it bogus because any fix requires output buffering behavior
> >>>> change
> > 
> > Sorry for top-posting. Anyway, reading the patch made me think that
> > maybe in the user/recoverable cases the output buffer should not be
> > discarded like this..?
> > 
> > And IMO, it's a bug, bugs should be fixed even if it means changing the
> > behaviour in an _edge_ case.
> 
> I'm not so sure as http://www.php.net/manual/en/function.ob-start.php
> doesn't make difference between successful and unsuccessful request and
> assumes "output buffer is flushed to the browser at the end of the request".

I think that it is critical to output this kind of buffer in case of fatal 
error, as it may unexpectedly leak data which was not meant to be output. It 
seems Ok to me to discard this kind of buffers in this case.

> 
> > How do those session tests fail..?
> 
> As they have ob_start() at top, the output is discarded and only error
> message is printed.
> 
> > They expect output with fatal errors? (actually those tests failed
> > without your patch too, IIRC :)
> 
> They works for me without the patch.
> 
> Thanks. Dmitry.
> 
> > --Jani
> > 
> 

Regards,

Arnaud