Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:40209 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81832 invoked from network); 2 Sep 2008 09:28:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2008 09:28:43 -0000 Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.163 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.163 il-gw1.zend.com Windows 2000 SP4, XP SP1 Received: from [212.25.124.163] ([212.25.124.163:17784] helo=il-gw1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 11/E0-10645-A470DB84 for ; Tue, 02 Sep 2008 05:28:43 -0400 Received: from ws.home ([10.1.1.1]) by il-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 2 Sep 2008 12:29:47 +0300 Message-ID: <48BD0746.8070103@zend.com> Date: Tue, 02 Sep 2008 13:28:38 +0400 User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: jani.taskinen@iki.fi CC: Arnaud Le Blanc , Lukas Kahwe Smith , Marcus Boerger , Stanislav Malyshev , PHP Internals List References: <48BCFF84.9080801@zend.com> <48BD057A.9090007@sci.fi> In-Reply-To: <48BD057A.9090007@sci.fi> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 02 Sep 2008 09:29:47.0132 (UTC) FILETIME=[70C9DBC0:01C90CDE] Subject: Re: [PHP-DEV] BUG #45392 From: dmitry@zend.com (Dmitry Stogov) Jani Taskinen wrote: > IIRC, there was some sort of OB rewrite done in HEAD..is this bug only > present in PHP_5_3? If so, I'd say the OB rewrite should be done in > PHP_5_3 already.. The bug occurs in both 5.3 and HEAD. Thanks. Dmitry. > --Jani > > > Dmitry Stogov wrote: >> Hi, >> >> Attached is a proposed fix for http://bugs.php.net/bug.php?id=45392 for >> PHP_5_3. I don't know output buffering part very well, and I'm not >> completely sure about this fix, so please review it. >> >> The patch changes behavior of output buffering a bit. In case of fatal >> error all output buffers opened by ob_start() with zero (or omitted) >> chunk_size argument are discarded. The fix brakes two tests: >> >> Test session_module_name() function : variation >> [ext/session/tests/session_module_name_variation3.phpt] >> Test session_set_save_handler() function : error functionality >> [ext/session/tests/session_set_save_handler_error3.phpt] >> >> We need to make a decision about #45392. >> >> 1) Fix it with proposed (or similar) patch >> >> 2) Make it bogus because any fix requires output buffering behavior >> change >> >> Thanks. Dmitry. >> >