Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40208
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.179 cause and error)
Message-ID: <48BD057A.9090007@sci.fi>
Date: Tue, 02 Sep 2008 12:20:58 +0300
Reply-To: jani.taskinen@iki.fi
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>
CC: Arnaud Le Blanc <arnaud.lb@gmail.com>, 
 Lukas Kahwe Smith <mls@pooteeweet.org>,
 Marcus Boerger <helly@php.net>, Stanislav Malyshev <stas@zend.com>, 
 PHP Internals List <internals@lists.php.net>
References: <48BCFF84.9080801@zend.com>
In-Reply-To: <48BCFF84.9080801@zend.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] BUG #45392
From: jani.taskinen@sci.fi (Jani Taskinen)

IIRC, there was some sort of OB rewrite done in HEAD..is this bug only 
present in PHP_5_3? If so, I'd say the OB rewrite should be done in 
PHP_5_3 already..

--Jani


Dmitry Stogov wrote:
> Hi,
> 
> Attached is a proposed fix for http://bugs.php.net/bug.php?id=45392 for
> PHP_5_3. I don't know output buffering part very well, and I'm not
> completely sure about this fix, so please review it.
> 
> The patch changes behavior of output buffering a bit. In case of fatal
> error all output buffers opened by ob_start() with zero (or omitted)
> chunk_size argument are discarded. The fix brakes two tests:
> 
> Test session_module_name() function : variation
> [ext/session/tests/session_module_name_variation3.phpt]
> Test session_set_save_handler() function : error functionality
> [ext/session/tests/session_set_save_handler_error3.phpt]
> 
> We need to make a decision about #45392.
> 
> 1) Fix it with proposed (or similar) patch
> 
> 2) Make it bogus because any fix requires output buffering behavior change
> 
> Thanks. Dmitry.
>