Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:40201 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 87697 invoked from network); 1 Sep 2008 14:40:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Sep 2008 14:40:56 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 66.249.92.174 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 66.249.92.174 ug-out-1314.google.com Received: from [66.249.92.174] ([66.249.92.174:61565] helo=ug-out-1314.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2A/0A-55699-6FEFBB84 for ; Mon, 01 Sep 2008 10:40:56 -0400 Received: by ug-out-1314.google.com with SMTP id c2so1571170ugf.37 for ; Mon, 01 Sep 2008 07:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:mime-version:content-type:content-transfer-encoding :content-disposition; bh=bDc5DAEOtsQSb4LhqKCBD7Y7/c+wiTaPd3DVBp3dvxE=; b=cDxxxnbPQKn/pmUBdKPLE9KzVQ4LjTDpXsxFnFPBNCy+eZE7veyo7uFr0KoYMfYRIM /vRrDpDk5Z7ORX2xk48sOEk8XS0SKLvwnc1zeWGNY/fOgdvBcb135kVCeAVdnsKSTrEl j/5CU9zHc5BifPkYNCXsfXwEMP0t0N+YNFl2w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:mime-version:content-type :content-transfer-encoding:content-disposition; b=C/ZNMDElcJc21b2oZjdVcFwiEqGbBmqNGYnY33lBkB0u1HHMOJ8Vfy1rPsJzKHcOld tsBSi38AsWlWqjpzYKW1NCXDFc6hmlqVEn9CHaAiRBYXRrPFYlhlkswnq6aa7UAMhaOU VAMJN3bXscZgSDeCA5qZjeJllR92HprQP0bUU= Received: by 10.67.94.12 with SMTP id w12mr2740594ugl.25.1220280050449; Mon, 01 Sep 2008 07:40:50 -0700 (PDT) Received: by 10.67.96.10 with HTTP; Mon, 1 Sep 2008 07:40:50 -0700 (PDT) Message-ID: Date: Mon, 1 Sep 2008 16:40:50 +0200 To: "PHP Internals List" Cc: "=?ISO-8859-1?Q?Johannes_Schl=FCter?=" , "Lukas Kahwe Smith" , "Ilia Alshanetsky" , "Derick Rethans" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: fileinfo portability fixes, stream usages and cleanup, #1 From: pierre.php@gmail.com ("Pierre Joye") hi all, Please find the patch here: http://pierre.libgd.org/patches/fileinfo_stream_cleanup.txt what it does is: - add stream support - removes duplicate codes (can still be better but it can be done later) - improve portabability (and fixing portability issues in php's stream will fix fileinfo too) It has been tested on windows and linux, the tests pass and no leak or crash has been found. The next steps (post alpha2) would be: - add more tests - finish the code cleanup (the code can be greatly simplified and rely only on the parser and db loader/compiler instead of the full lib) - add compression support Please test, review or comment, the commit is due before alpha2 packaging phase (today). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org