Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40127
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.235.152.152 cause and error)
Message-ID: <012201c909bd$580f0ca0$0201a8c0@pc1>
To: <internals@lists.php.net>, "Dmitry Stogov" <dmitry@zend.com>
References: <00ea01c8a160$2edd8160$0201a8c0@pc1> <016c01c8eccd$e28cfac0$0201a8c0@pc1> <488835D0.1040005@zend.com> <00e501c8ed77$3498cf20$0201a8c0@pc1> <48889901.8000008@zend.com> <015101c8f306$34c358f0$0201a8c0@pc1> <4891CC46.2020208@zend.com> <020e01c8f32e$a82a9fb0$0201a8c0@pc1> <4891F189.7030202@zend.com> <00be01c90919$0592d0f0$0201a8c0@pc1> <48B7BF19.5020007@zend.com>
Date: Fri, 29 Aug 2008 04:55:16 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] No runtime fetching of built-in global constants
From: php_lists@realplain.com ("Matt Wilmas")

Hi Dmitry,

Yeah, that looks good too, and should work the same way. :-)


Thanks,
Matt


----- Original Message -----
From: "Dmitry Stogov"
Sent: Friday, August 29, 2008

> Hi Matt,
>
> I updated your patch a little bit to make it more clear (from my point
> of view).
> Please take a look.
>
> Thanks. Dmitry.
>
> Matt Wilmas wrote:
> > Hi Dmitry,
> >
> > Well, it's been awhile since Alpha 1 :-), so I wanted to finally resend
this
> > before Alpha 2!  I agree that the additional optimization probably
wouldn't
> > happen often, as there won't be that much namespace usage right away, I
> > assume.  But I think it makes sense to handle :: prefix constants, since
> > they're known to have global scope, and I can see the future [online]
> > optimization tip: "When using namespaces, use :: for global constants to
get
> > compile-time substitution." ;-)
> >
> > The code is the same as before, just updated the patch.  It doesn't
really
> > seem less clear, to me, than the current code.  In
zend_do_fetch_constant(),
> > the "check_namespace" variable may be better named something like
> > "from_namespace" according to my changes, to be more clear, but I left
that
> > out to make the patch as simple as possible.
> >
> > http://realplain.com/php/ct_const_fixes.diff
> > http://realplain.com/php/ct_const_fixes_5_3.diff
> >
> >
> > Thanks,
> > Matt