Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40120
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.235.152.148 cause and error)
Message-ID: <00e801c9091a$e1eac930$0201a8c0@pc1>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@php.net>
Cc: <internals@lists.php.net>
References: <01b401c8ec13$28cd3510$0201a8c0@pc1> <1217505976.5408.34.camel@goldfinger.johannes.nop> <01fc01c8f32d$3f42a7f0$0201a8c0@pc1> <1217527569.5408.65.camel@goldfinger.johannes.nop> <1217542905.4168.1.camel@goldfinger.johannes.nop>
Date: Thu, 28 Aug 2008 09:32:19 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] New functions: array_replace[_recursive]
From: php_lists@realplain.com ("Matt Wilmas")

Hi Johannes,

----- Original Message -----
From: "Johannes Schlüter"
Sent: Thursday, July 31, 2008

> Matt,
>
> On Thu, 2008-07-31 at 20:06 +0200, Johannes Schlüter wrote:
> > On Thu, 2008-07-31 at 11:48 -0500, Matt Wilmas wrote:
> > > Ugh, I hate that reference/recursion stuff!  I have a hard time
following
> > > what's happening, and am not sure how some of those checks, etc. even
work
> > > in php_array_merge() (which I was working from). :-/  I tried changing
a few
> > > parts, and unfortunately couldn't fix it.  I will look at it further
when I
> > > have some more time, and will of course let you know if it's fixed.
Sorry.
> > > :-(
> >
> > I think I found a thing: you're iterating over src and src_entry, but
> > doing the recursion check using Z_ARRVAL_PP(dest_entry)->nApplyCount, I
> > didn't test it (need food first) but should do that with src_entry.
>
> FYI: that assumption seems to be correct and I committed it including
> the fix :-)

Uhh, it's been pretty long now (was sidetracked by non-PHP stuff...), but I
forgot to thank you for getting that code working, so thanks!  (And it was
such a simple fix, heh. :-/)  Sorry, but better late than never I guess. :-)

> johannes

- Matt