Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:40020
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.163 as permitted sender)
To: Lucas Nealan <lnealan@facebook.com>
Cc: PHP Internals List <internals@lists.php.net>
In-Reply-To: <C4CB8B21.DDAF%lnealan@facebook.com>
References: <C4CB8B21.DDAF%lnealan@facebook.com>
Content-Type: text/plain
Date: Wed, 20 Aug 2008 19:47:24 +0200
Message-ID: <1219254444.6409.7.camel@goldfinger.johannes.nop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Apache 1.x sapi timeout name fix
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Hi,

is anybody with deeper Apache knowledge around who can review that?

Thnaks,
johannes

On Fri, 2008-08-15 at 19:36 -0700, Lucas Nealan wrote:
> Hello,
> 
> Apache 1.x SAPI will occasionally timeout with a "Read POST information
> timeout" error instead of a "send timeout" error as it should. This will
> happen if the alarm timeout occurs in a POST request, at any point after the
> post is read (ie. php_execute_script). This is because the
> hard_timeout("send") name set within send_php() is overridden by the
> hard_timeout("Read POST information") in sapi_apache_read_post() and never
> restored. 
> 
> I walked through the startup calls from the point where timeout is set in
> send_php to where the read post timeout is set. It seems highly unlikely
> that a timeout should happen in this code, even if it were set to 1. The
> patches below will correct the timeout name by moving the
> hard_timeout("send") from send_php() to php_apache_sapi_activate(), which is
> called just after the post is read.
> 
> http://sizzo.org/~screen/patches/php-5.3.0-timer_post.patch
> http://sizzo.org/~screen/patches/php-HEAD-timer_post.patch
> 
> -lucas
> 
>