Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39920
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error)
Cc: Marcus Boerger <helly@php.net>,
 Etienne Kneuss <colder@php.net>,
 Stanislav Malyshev <stas@zend.com>,
 hannes.magnusson@gmail.com,
 internals@lists.php.net
Message-ID: <66A41D6E-5CDF-4954-BF13-9ECF71038814@pooteeweet.org>
To: Lars Strojny <lars@strojny.net>
In-Reply-To: <1218634532.4926.5.camel@localhost>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v928.1)
Date: Wed, 13 Aug 2008 16:42:15 +0200
References: <909776579.20080803142659@marcus-boerger.de> <840985F2-A701-4BE4-91F6-F6B39048CF9B@pooteeweet.org> <48A09FF4.1030101@zend.com> <7f3ed2c30808111411t51553771j389f05c3436bc625@mail.gmail.com> <48A0C415.9090104@zend.com> <e666c3890808111702m5e95e83kc3b15afbf4cef99d@mail.gmail.com> <48A0D579.2000000@zend.com> <e666c3890808111721y25e21e32v2836897793a60822@mail.gmail.com> <48A0DBAE.2010401@zend.com> <e666c3890808111804j566024baqac63576276d969b5@mail.gmail.com> <496879481.20080812153636@marcus-boerger.de> <279600845.20080812225135@marcus-boerger.de> <1218621323.4926.1.camel@localhost> <1341995942.20080813152134@marcus-boerger.de> <1218634532.4926.5.camel@localhost>
Subject: Re: [PHP-DEV] Inconsistencies in 5.3
From: mls@pooteeweet.org (Lukas Kahwe Smith)


On 13.08.2008, at 15:35, Lars Strojny wrote:

> Hi Markus
>
> Am Mittwoch, den 13.08.2008, 15:21 +0200 schrieb Marcus Boerger:
> [...]
>> Namespaces are new, so it never worked before. But yes, this would  
>> trigger
>> a warning in the compiler which means you are told to not do this  
>> with apc
>> or other compiler caches.
>
> You are aware that this is used in a number of PHP libraries/ 
> frameworks?
> Additionally, a lot have code like this:
>
> class ...
>  public function foo()
>  {
>     if (!$this->_something) {
>         require_once 'Foo/Exception.php';
>         throw new FooException();
>     }
>  }

Right, this is quite common. So is including drivers inside factory  
methods. Even if they are not explicit, there is obviously also  
autoload.

Just so that I get straight why we are doing this:
The namespace of the file is not magically applied to the included  
code, so instead one would expect the included code to set the  
relevant namespace itself.

Now for any library that would use namespaces and have an include  
inside that namespace, it would also set a namespace in the included  
file or its likely a bug. Not sure if we could only throw a warning if  
we do an include without a namespace being defined in the file that is  
being included? That starts being quite fancy in terms of error  
handling though, which even if doable probably adds overhead?

The other situation I see would be a namespaced template engine that  
loads some template who's content is not namespaced explicitly. It  
does not really make sense to start defining namespaces in templates  
just to get around that warning.

> I guess most of the time those using OP caches know what they are  
> doing.
> So why should a warning be triggered here?


Thats a pretty big assumption.

regards,
Lukas Kahwe Smith
mls@pooteeweet.org