Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39871 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55710 invoked from network); 12 Aug 2008 14:01:01 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Aug 2008 14:01:01 -0000 Authentication-Results: pb1.pair.com smtp.mail=tony@daylessday.org; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tony@daylessday.org; sender-id=pass Received-SPF: pass (pb1.pair.com: domain daylessday.org designates 89.208.40.236 as permitted sender) X-PHP-List-Original-Sender: tony@daylessday.org X-Host-Fingerprint: 89.208.40.236 mail.daylessday.org Linux 2.6 Received: from [89.208.40.236] ([89.208.40.236:42847] helo=daylessday.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9B/0E-04075-C9791A84 for ; Tue, 12 Aug 2008 10:01:00 -0400 Received: from [192.168.3.254] (unknown [212.42.62.198]) by daylessday.org (Postfix) with ESMTP id 45748640166; Tue, 12 Aug 2008 18:00:51 +0400 (MSD) Message-ID: <48A19790.20305@daylessday.org> Date: Tue, 12 Aug 2008 18:00:48 +0400 User-Agent: Thunderbird 2.0.0.12 (X11/20071114) MIME-Version: 1.0 To: Phil Oleson CC: PHP Internals List References: <48A07CE7.7010404@nixil.net> In-Reply-To: <48A07CE7.7010404@nixil.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] pspell tweak. From: tony@daylessday.org (Antony Dovgal) On 11.08.2008 21:54, Phil Oleson wrote: > Was running pspell through g++ and found that a couple of error conditions segments in pspell.c > are using the wrong cleanup methods. delete_pspell_manager() should be delete_pspell_can_have_error() We'd certainly need some more details to get this patch committed, not just "this should that". -- Wbr, Antony Dovgal