Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39863
Return-Path: <dmitry@zend.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 11328 invoked from network); 12 Aug 2008 08:08:42 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 12 Aug 2008 08:08:42 -0000
Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.163 as permitted sender)
X-PHP-List-Original-Sender: dmitry@zend.com
X-Host-Fingerprint: 212.25.124.163 il-gw1.zend.com Windows 2000 SP4, XP SP1
Received: from [212.25.124.163] ([212.25.124.163:49748] helo=il-gw1.zend.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 2F/16-04075-90541A84 for <internals@lists.php.net>; Tue, 12 Aug 2008 04:08:42 -0400
Received: from [10.1.10.18] ([10.1.10.18]) by il-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959);
	 Tue, 12 Aug 2008 11:09:28 +0300
Message-ID: <48A144FE.407@zend.com>
Date: Tue, 12 Aug 2008 12:08:30 +0400
User-Agent: Thunderbird 2.0.0.16 (Windows/20080708)
MIME-Version: 1.0
To: Rasmus Lerdorf <rasmus@lerdorf.com>
CC: Hannes Magnusson <hannes.magnusson@gmail.com>, 
 Greg Beaver <greg@chiaraquartet.net>,
 internals@lists.php.net
References: <4899C4B4.3060902@liip.ch> <1218138548.5346.3.camel@felipe>	 <489B5285.1070000@lerdorf.com>	 <200808072237.01841.arnaud.lb@gmail.com>	 <7f3ed2c30808080011l3c62d416k7fd9b4dd455df99e@mail.gmail.com>	 <489C6BBA.8030101@zend.com> <489D811D.6090401@sektioneins.de>	 <489E3623.50008@lerdorf.com> <489FD934.8090905@zend.com>	 <48A0B1FB.6080604@chiaraquartet.net> <7f3ed2c30808120021n438be34crf83f24ca169f8e3a@mail.gmail.com> <48A14240.1020600@lerdorf.com>
In-Reply-To: <48A14240.1020600@lerdorf.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 12 Aug 2008 08:09:29.0771 (UTC) FILETIME=[BEBE27B0:01C8FC52]
Subject: Re: [PHP-DEV] include bug in 5.3
From: dmitry@zend.com (Dmitry Stogov)

__FILE__. "/../../foobar.php" probably could work on Windows/BSD only, 
but won't work anymore.

The patch is committed.

Thanks. Dmitry.

Rasmus Lerdorf wrote:
>>> Does this change affect code like:
>>>
>>> include "../file.php";
> 
> That will work fine.
> 
>> I was thinking along the same line. I bet some people have been lazy
>> and used __FILE__. "/../../foobar.php".
> 
> That will not work.  And that is moronic code anyway.  Why wouldn't they 
> use __DIR__ there?
> 
> -Rasmus