Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39846
Return-Path: <helly@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 39566 invoked from network); 11 Aug 2008 23:13:49 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 11 Aug 2008 23:13:49 -0000
Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
X-PHP-List-Original-Sender: helly@php.net
X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6
Received: from [85.214.94.56] ([85.214.94.56:59496] helo=h1149922.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BF/92-25857-BA7C0A84 for <internals@lists.php.net>; Mon, 11 Aug 2008 19:13:48 -0400
Received: from MBOERGER-ZRH.corp.google.com (139-85.107-92.cust.bluewin.ch [92.107.85.139])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by h1149922.serverkompetenz.net (Postfix) with ESMTP id 3E69C11DB47;
	Tue, 12 Aug 2008 01:13:43 +0200 (CEST)
Date: Tue, 12 Aug 2008 01:13:11 +0200
Reply-To: Marcus Boerger <helly@php.net>
X-Priority: 3 (Normal)
Message-ID: <218019803.20080812011311@marcus-boerger.de>
To: Christian Seiler <chris_se@gmx.net>
CC: php-dev List <internals@lists.php.net>
In-Reply-To: <48A0BE81.80705@gmx.net>
References: <48886651.80407@gmx.net> <4889F43D.8030609@gmx.net> <4896B0B4.2090801@zend.com> <1217847553.4175.23.camel@goldfinger.johannes.nop> <875726149.20080808234837@marcus-boerger.de> <803831941.20080809003459@marcus-boerger.de> <1199358810.20080811005138@marcus-boerger.de> <489FFDA0.4080206@zend.com> <1446091491.20080811122357@marcus-boerger.de> <302695240.20080811144502@marcus-boerger.de> <48A08853.6020403@gmx.net> <1714419722.20080811214021@marcus-boerger.de> <48A0BE81.80705@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Closures and reflection improvements
From: helly@php.net (Marcus Boerger)

Hello Christian,

Tuesday, August 12, 2008, 12:34:41 AM, you wrote:

> Hi Marcus,

>> Account approved and access granted.

> Thanks!

>> Please provide the function copying in a function next to _free_function()

> I just committed that (and included some tests). I hope I didn't do
> anything wrong in the process, if so, feel free to do so.

>> and care for parameter info as well

> I assume with parameter info you mean arg_info? That isn't necessary and
> actually harmful since the arg_info is not copied but simply referenced
> via a C pointer in closures (zend_get_closure_invoke_method copies the
> entire function structure, including the pointer to arg_info and only
> changes some flags the function name). There is no need to copy or
> destroy arg_info in reflection.

Oh, cool. I thought we'd have to do more stuff.

>> Also for your next patches (cvs di -N) allows to ship the new files in the
>> patch and (cvs di -Np) shows the context, which makes reading the patches
>> easier.

> Ah, thanks, I added that to my .cvsrc.

> Regards,
> Christan




Best regards,
 Marcus