Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39844
Return-Path: <chris_se@gmx.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 32697 invoked from network); 11 Aug 2008 22:36:25 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 11 Aug 2008 22:36:25 -0000
Authentication-Results: pb1.pair.com smtp.mail=chris_se@gmx.net; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=chris_se@gmx.net; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmx.net designates 213.165.64.20 as permitted sender)
X-PHP-List-Original-Sender: chris_se@gmx.net
X-Host-Fingerprint: 213.165.64.20 mail.gmx.net  
Received: from [213.165.64.20] ([213.165.64.20:45416] helo=mail.gmx.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id CA/51-25857-6EEB0A84 for <internals@lists.php.net>; Mon, 11 Aug 2008 18:36:24 -0400
Received: (qmail invoked by alias); 11 Aug 2008 22:36:19 -0000
Received: from p54A15B4E.dip.t-dialin.net (EHLO chris-se.dyndns.org) [84.161.91.78]
  by mail.gmx.net (mp062) with SMTP; 12 Aug 2008 00:36:19 +0200
X-Authenticated: #186999
X-Provags-ID: V01U2FsdGVkX1+wEclSXtKwwaQEO87DM+FCcvVLWts8uvujugAEQe
	es3+1vxlmc90Or
Received: from [192.168.100.13] (cobalt.seiler.lan [192.168.100.13])
	by chris-se.dyndns.org (Postfix) with ESMTP id 645361AF00;
	Mon, 11 Aug 2008 23:53:49 +0200 (CEST)
Message-ID: <48A0BE81.80705@gmx.net>
Date: Tue, 12 Aug 2008 00:34:41 +0200
User-Agent: Thunderbird 2.0.0.16 (X11/20080707)
MIME-Version: 1.0
To: Marcus Boerger <helly@php.net>
CC: php-dev List <internals@lists.php.net>
References: <48886651.80407@gmx.net> <4889F43D.8030609@gmx.net> <4896B0B4.2090801@zend.com> <1217847553.4175.23.camel@goldfinger.johannes.nop> <875726149.20080808234837@marcus-boerger.de> <803831941.20080809003459@marcus-boerger.de> <1199358810.20080811005138@marcus-boerger.de> <489FFDA0.4080206@zend.com> <1446091491.20080811122357@marcus-boerger.de> <302695240.20080811144502@marcus-boerger.de> <48A08853.6020403@gmx.net> <1714419722.20080811214021@marcus-boerger.de>
In-Reply-To: <1714419722.20080811214021@marcus-boerger.de>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.74
Subject: Re: [PHP-DEV] [PATCH] Closures and reflection improvements
From: chris_se@gmx.net (Christian Seiler)

Hi Marcus,

> Account approved and access granted.

Thanks!

> Please provide the function copying in a function next to _free_function()

I just committed that (and included some tests). I hope I didn't do
anything wrong in the process, if so, feel free to do so.

> and care for parameter info as well

I assume with parameter info you mean arg_info? That isn't necessary and
actually harmful since the arg_info is not copied but simply referenced
via a C pointer in closures (zend_get_closure_invoke_method copies the
entire function structure, including the pointer to arg_info and only
changes some flags the function name). There is no need to copy or
destroy arg_info in reflection.

> Also for your next patches (cvs di -N) allows to ship the new files in the
> patch and (cvs di -Np) shows the context, which makes reading the patches
> easier.

Ah, thanks, I added that to my .cvsrc.

Regards,
Christan