Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39833 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 53099 invoked from network); 11 Aug 2008 17:54:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Aug 2008 17:54:58 -0000 Authentication-Results: pb1.pair.com smtp.mail=oz@nixil.net; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=oz@nixil.net; sender-id=pass Received-SPF: pass (pb1.pair.com: domain nixil.net designates 161.58.222.1 as permitted sender) X-PHP-List-Original-Sender: oz@nixil.net X-Host-Fingerprint: 161.58.222.1 nixil.net FreeBSD 4.6-4.9 Received: from [161.58.222.1] ([161.58.222.1:2980] helo=nixil.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 16/56-30561-FEC70A84 for ; Mon, 11 Aug 2008 13:54:56 -0400 Received: from demigorgon.corp.verio.net (fw.oremut02.us.wh.verio.net [198.65.168.24]) (authenticated bits=0) by nixil.net (8.13.6.20060614/8.13.6) with ESMTP id m7BHslfd085356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 11 Aug 2008 11:54:53 -0600 (MDT) Message-ID: <48A07CE7.7010404@nixil.net> Date: Mon, 11 Aug 2008 11:54:47 -0600 User-Agent: Thunderbird 2.0.0.14 (X11/20080623) MIME-Version: 1.0 To: PHP Internals List Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (nixil.net [161.58.222.1]); Mon, 11 Aug 2008 11:54:53 -0600 (MDT) X-Virus-Scanned: ClamAV 0.93.1/8007/Mon Aug 11 07:51:54 2008 on nixil.net X-Virus-Status: Clean Subject: pspell tweak. From: oz@nixil.net (Phil Oleson) Was running pspell through g++ and found that a couple of error conditions segments in pspell.c are using the wrong cleanup methods. delete_pspell_manager() should be delete_pspell_can_have_error() -Phil. --- pspell.c 16 Jul 2008 18:35:41 -0000 1.61 +++ pspell.c 11 Aug 2008 17:39:03 -0000 @@ -374,7 +374,7 @@ if(pspell_error_number(ret) != 0){ php_error_docref(NULL TSRMLS_CC, E_WARNING, "PSPELL couldn't open the dictionary. reason: %s", pspell_error_message(ret)); - delete_pspell_manager(ret); + delete_pspell_can_have_error(ret); RETURN_FALSE; } @@ -492,7 +492,7 @@ if(pspell_error_number(ret) != 0){ php_error_docref(NULL TSRMLS_CC, E_WARNING, "PSPELL couldn't open the dictionary. reason: %s", pspell_error_message(ret)); - delete_pspell_manager(ret); + delete_pspell_can_have_error(ret); RETURN_FALSE; } @@ -526,7 +526,7 @@ if(pspell_error_number(ret) != 0){ php_error_docref(NULL TSRMLS_CC, E_WARNING, "PSPELL couldn't open the dictionary. reason: %s", pspell_error_message(ret)); - delete_pspell_manager(ret); + delete_pspell_can_have_error(ret); RETURN_FALSE; }