Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39809 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96823 invoked from network); 10 Aug 2008 15:31:46 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Aug 2008 15:31:46 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.232 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.198.232 rv-out-0506.google.com Received: from [209.85.198.232] ([209.85.198.232:28805] helo=rv-out-0506.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 93/1D-05869-0E90F984 for ; Sun, 10 Aug 2008 11:31:45 -0400 Received: by rv-out-0506.google.com with SMTP id g37so1828790rvb.23 for ; Sun, 10 Aug 2008 08:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=/JstF0ciRoTMGXd5se2edJi9MGl3AQYBboIHM5oP/lw=; b=G7RYHJA0qnlch40hgvh5H8oasqF54p/RevenMhyMLaaU9llpgYQRVTk4xepoA/XSRz IsHx8m5p8JHrmXDZCgzdKHQvKKjo1zljJwGswd43rZBo2hiVp9TM7rjFnSITchdSoUhz eUjol8L6WhllfIYl8etUEM0cimnaANQf72J5g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=gL74lrgTdE9ncCo+8vJyZzdhFCcpWk+O2mKALal5m/kXXutOAKnPixEUCvTOWtA5ho UFrFTc2/PlUUQZKsbeTBNMc+z0/lhzLKX29IvHybwuiHoXMcAAcZ7cmx7ZtQJ9p1n1vk CxaBNTb3ImOVksniXddFf8J2DQWGv/tiQv5MA= Received: by 10.141.29.8 with SMTP id g8mr2846525rvj.62.1218382301554; Sun, 10 Aug 2008 08:31:41 -0700 (PDT) Received: by 10.141.185.2 with HTTP; Sun, 10 Aug 2008 08:31:41 -0700 (PDT) Message-ID: Date: Sun, 10 Aug 2008 17:31:41 +0200 To: "PHP Internals" MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Subject: run-tests.php esacapeshellarg, portability From: pierre.php@gmail.com ("Pierre Joye") hi! While fixing broken tests (linux or win), I found that shell arguments are manually escaped. Using escapeshellargs is more portable and avoid duplicate tests only to fix shell argument issues (& usage for example). Here is a patch to add escapeshellarg usage: http://pierre.libgd.org/patches/runtests_5_3_escapeshellarg.patch.txt A couple of tests need changes, like: inisetting="foo" will become inisetting=foo or inisetting="" to inisetting= Please test the patch or let me know if you have any objection :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org