Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39790 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 63585 invoked from network); 9 Aug 2008 06:43:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Aug 2008 06:43:26 -0000 Authentication-Results: pb1.pair.com smtp.mail=christian.stocker@liip.ch; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=christian.stocker@liip.ch; sender-id=unknown Received-SPF: error (pb1.pair.com: domain liip.ch from 194.50.176.162 cause and error) X-PHP-List-Original-Sender: christian.stocker@liip.ch X-Host-Fingerprint: 194.50.176.162 mail.bitflux.ch Linux 2.5 (sometimes 2.4) (4) Received: from [194.50.176.162] ([194.50.176.162:37255] helo=devel.bitflux.ch) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F9/28-02575-C8C3D984 for ; Sat, 09 Aug 2008 02:43:25 -0400 Received: from localhost (localhost [127.0.0.1]) by devel.bitflux.ch (Postfix) with ESMTP id C70D7E76EF; Sat, 9 Aug 2008 08:43:20 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at devel.bitflux.ch Received: from devel.bitflux.ch ([127.0.0.1]) by localhost (devel.bitflux.ch [127.0.0.1]) (amavisd-new, port 10024) with LMTP id L9ZuWGnPdPFH; Sat, 9 Aug 2008 08:43:14 +0200 (CEST) Received: from [192.168.84.16] (office-zh.liip.ch [91.192.102.250]) by devel.bitflux.ch (Postfix) with ESMTP id 1428BE76E9; Sat, 9 Aug 2008 08:43:14 +0200 (CEST) Message-ID: <489D3C82.3000008@liip.ch> Date: Sat, 09 Aug 2008 08:43:14 +0200 User-Agent: Thunderbird 2.0.0.16 (Macintosh/20080707) MIME-Version: 1.0 To: Dmitry Stogov CC: Hannes Magnusson , Arnaud Le Blanc , internals@lists.php.net, Rasmus Lerdorf , Felipe Pena , Andi Gutmans , Stanislav Malyshev References: <4899C4B4.3060902@liip.ch> <1218138548.5346.3.camel@felipe> <489B5285.1070000@lerdorf.com> <200808072237.01841.arnaud.lb@gmail.com> <7f3ed2c30808080011l3c62d416k7fd9b4dd455df99e@mail.gmail.com> <489C6BBA.8030101@zend.com> In-Reply-To: <489C6BBA.8030101@zend.com> X-Enigmail-Version: 0.95.6 OpenPGP: id=5CE1DECB Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] include bug in 5.3 From: christian.stocker@liip.ch (Christian Stocker) Hi Dmitry On 8.8.2008 17:52 Uhr, Dmitry Stogov wrote: > Hi, > > The attached patch is going to fix the problem. Works also on my OS X 10.4 box now. Thanks a lot for the effort (and if it brings a performance boost, even better :) ) chregu > It implements its own realpath() function, so we won't depend on system > anymore. It also improve realpath cache usage by caching intermediate > results. > > I tested it on Linux and Windows only and it seems to work without > problems. It breaks one test related to clearstatcache() function, but > this break is expected. > > Could you please test it. > Does it really fix the bug on FreeBSD? > > Thanks. Dmitry. > > > Hannes Magnusson wrote: >> On Thu, Aug 7, 2008 at 22:37, Arnaud Le Blanc wrote: >>> virtual_file_ex() assumes that realpath() returns NULL when the file does not >>> exists. But BSD's realpath() will not return NULL if all >>> components *but the last* exist. So realpath(/foo/bar) will return /foo/bar >>> even if bar does not exists. >> And that behavior is intended, but is sadly overwritten in ZTS :( >> >> -Hannes -- New Office Zurich Opening: http://liip.to/party -- Liip AG // Feldstrasse 133 // CH-8004 Zurich Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 www.liip.ch // blog.liip.ch // GnuPG 0x5CE1DECB