Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39776
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <489CBE81.5030003@lerdorf.com>
Date: Fri, 08 Aug 2008 14:45:37 -0700
User-Agent: Thunderbird/3.0a2pre (Macintosh; 2008071516)
MIME-Version: 1.0
To: Dmitry Stogov <dmitry@zend.com>
CC: Hannes Magnusson <hannes.magnusson@gmail.com>,
        Arnaud Le Blanc <arnaud.lb@gmail.com>, internals@lists.php.net,
        Felipe Pena <felipensp@gmail.com>,
        Christian Stocker <christian.stocker@liip.ch>,
        Andi Gutmans <andi@zend.com>, Stanislav Malyshev <stas@zend.com>
References: <4899C4B4.3060902@liip.ch> <1218138548.5346.3.camel@felipe>	 <489B5285.1070000@lerdorf.com>	 <200808072237.01841.arnaud.lb@gmail.com> <7f3ed2c30808080011l3c62d416k7fd9b4dd455df99e@mail.gmail.com> <489C6BBA.8030101@zend.com> <489CBDD8.6070502@lerdorf.com>
In-Reply-To: <489CBDD8.6070502@lerdorf.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] include bug in 5.3
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Rasmus Lerdorf wrote:
> Dmitry Stogov wrote:
>> Hi,
>>
>> The attached patch is going to fix the problem.
>> It implements its own realpath() function, so we won't depend on system
>> anymore. It also improve realpath cache usage by caching intermediate
>> results.
>
> Very nice. The intermediate caching is going to drastically reduce the
> amount of memory we need for the cache. I have seen a number of cases
> where sites had to increase the realpath cache size by quite a bit.

Oh, and on top of that we also get a big performance improvement for 
include_path misses since we no longer have to re-stat every component 
of the docroot on every miss.

-Rasmus