Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39774 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88209 invoked from network); 8 Aug 2008 21:28:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Aug 2008 21:28:58 -0000 Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 63.208.196.178 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 63.208.196.178 mho-01-bos.mailhop.org Received: from [63.208.196.178] ([63.208.196.178:63977] helo=mho-01-bos.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id C2/48-46174-89ABC984 for ; Fri, 08 Aug 2008 17:28:57 -0400 Received: from cs78255253.pp.htv.fi ([62.78.255.253] helo=[127.0.0.1]) by mho-01-bos.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1KRZVj-0004xg-KO; Fri, 08 Aug 2008 21:28:35 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 62.78.255.253 X-Report-Abuse-To: abuse@dyndns.com (see http://www.mailhop.org/outbound/abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/QRCj3k3ZTH2e+2tilkUowqk58UFOX2dw= Message-ID: <489CBA72.1070705@sci.fi> Date: Sat, 09 Aug 2008 00:28:18 +0300 Reply-To: jani.taskinen@iki.fi User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Dmitry Stogov CC: Hannes Magnusson , Arnaud Le Blanc , internals@lists.php.net, Rasmus Lerdorf , Felipe Pena , Christian Stocker , Andi Gutmans , Stanislav Malyshev References: <4899C4B4.3060902@liip.ch> <1218138548.5346.3.camel@felipe> <489B5285.1070000@lerdorf.com> <200808072237.01841.arnaud.lb@gmail.com> <7f3ed2c30808080011l3c62d416k7fd9b4dd455df99e@mail.gmail.com> <489C6BBA.8030101@zend.com> In-Reply-To: <489C6BBA.8030101@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] include bug in 5.3 From: jani.taskinen@sci.fi (Jani Taskinen) Just semantics but I'd name the function 'tsrm_realpath[_r]' to be absolutely clear what it does. --Jani Dmitry Stogov kirjoitti: > Hi, > > The attached patch is going to fix the problem. > It implements its own realpath() function, so we won't depend on system > anymore. It also improve realpath cache usage by caching intermediate > results. > > I tested it on Linux and Windows only and it seems to work without > problems. It breaks one test related to clearstatcache() function, but > this break is expected. > > Could you please test it. > Does it really fix the bug on FreeBSD? > > Thanks. Dmitry. > > > Hannes Magnusson wrote: >> On Thu, Aug 7, 2008 at 22:37, Arnaud Le Blanc wrote: >>> virtual_file_ex() assumes that realpath() returns NULL when the file does not >>> exists. But BSD's realpath() will not return NULL if all >>> components *but the last* exist. So realpath(/foo/bar) will return /foo/bar >>> even if bar does not exists. >> And that behavior is intended, but is sadly overwritten in ZTS :( >> >> -Hannes