Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39763 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35926 invoked from network); 8 Aug 2008 18:04:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Aug 2008 18:04:55 -0000 Authentication-Results: pb1.pair.com smtp.mail=dmitry@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=dmitry@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.163 as permitted sender) X-PHP-List-Original-Sender: dmitry@zend.com X-Host-Fingerprint: 212.25.124.163 il-gw1.zend.com Windows 2000 SP4, XP SP1 Received: from [212.25.124.163] ([212.25.124.163:17468] helo=il-gw1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 61/3B-01800-6CA8C984 for ; Fri, 08 Aug 2008 14:04:55 -0400 Received: from tpl.home ([10.1.1.1]) by il-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 8 Aug 2008 21:05:38 +0300 Message-ID: <489C8AB8.8090008@zend.com> Date: Fri, 08 Aug 2008 22:04:40 +0400 User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Arnaud Le Blanc CC: Hannes Magnusson , internals@lists.php.net, Rasmus Lerdorf , Felipe Pena , Christian Stocker , Andi Gutmans , Stanislav Malyshev References: <4899C4B4.3060902@liip.ch> <7f3ed2c30808080011l3c62d416k7fd9b4dd455df99e@mail.gmail.com> <489C6BBA.8030101@zend.com> <200808081930.19404.arnaud.lb@gmail.com> In-Reply-To: <200808081930.19404.arnaud.lb@gmail.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 08 Aug 2008 18:05:39.0968 (UTC) FILETIME=[5DCA1000:01C8F981] Subject: Re: [PHP-DEV] include bug in 5.3 From: dmitry@zend.com (Dmitry Stogov) Great! :) It's mean I'm on the right way. The patch still needs additional work and testing, but I hope it'll be ready before alpha 2. Thanks. Dmitry. Arnaud Le Blanc wrote: > Hi, > > On Friday 08 August 2008 17:52:26 Dmitry Stogov wrote: >> Hi, >> >> The attached patch is going to fix the problem. >> It implements its own realpath() function, so we won't depend on system >> anymore. It also improve realpath cache usage by caching intermediate >> results. >> >> I tested it on Linux and Windows only and it seems to work without >> problems. It breaks one test related to clearstatcache() function, but >> this break is expected. >> >> Could you please test it. >> Does it really fix the bug on FreeBSD? > > Yes, it fixes the bug on FreeBSD :) > >> Thanks. Dmitry. >> >> Hannes Magnusson wrote: >>> On Thu, Aug 7, 2008 at 22:37, Arnaud Le Blanc wrote: >>>> virtual_file_ex() assumes that realpath() returns NULL when the file >>>> does not exists. But BSD's realpath() will not return NULL if all >>>> components *but the last* exist. So realpath(/foo/bar) will return >>>> /foo/bar even if bar does not exists. >>> And that behavior is intended, but is sadly overwritten in ZTS :( >>> >>> -Hannes > > Regards, > > Arnaud