Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39762 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 25404 invoked from network); 8 Aug 2008 17:32:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Aug 2008 17:32:08 -0000 Authentication-Results: pb1.pair.com smtp.mail=arnaud.lb@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=arnaud.lb@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.134.186 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: arnaud.lb@gmail.com X-Host-Fingerprint: 209.85.134.186 mu-out-0910.google.com Received: from [209.85.134.186] ([209.85.134.186:28627] helo=mu-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 69/19-01800-7138C984 for ; Fri, 08 Aug 2008 13:32:08 -0400 Received: by mu-out-0910.google.com with SMTP id i2so883586mue.3 for ; Fri, 08 Aug 2008 10:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=SjIFb+a7YxXTWJLOGY44cHUxW42YN+9njAM2IU5sprQ=; b=JTRgRT4cfCiEfQAVl8HyWhUtDIRCost0pzQbc6zw+0A/5HvhZTqibS5PZUB3fpKBYM 69SkKcpb7cOHKztyeQhOJrO1ZdoMhQo6M1tnC5mM5wqd02NGfuZaafUO8LgdiPu9f48+ vNAPeSL5WG2PqjFvZjj3Z9gPXAgYIJID9/fMg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=FEVXB3ZXcr/flrhYuJWMB2gPz9mNBA660xADS4uo+OijcQguGBH6aXEeXQxST72vp9 LBPq1JK5EqmjmvkoPJJUISllk0RAW2Y07L8UrA7Y0puhSdwXL4IyDqoChN+UzP0yCxWT VGJhNdTbqXDpGdOrwlS+N5KW73zzYkpc/92jg= Received: by 10.103.137.19 with SMTP id p19mr3330315mun.108.1218216724922; Fri, 08 Aug 2008 10:32:04 -0700 (PDT) Received: from 207-177-41-213.getmyip.com ( [213.41.177.207]) by mx.google.com with ESMTPS id e8sm3351800muf.0.2008.08.08.10.32.02 (version=SSLv3 cipher=RC4-MD5); Fri, 08 Aug 2008 10:32:03 -0700 (PDT) To: Dmitry Stogov Date: Fri, 8 Aug 2008 19:30:18 +0200 User-Agent: KMail/1.10.0 (Linux/2.6.26-noch; KDE/4.1.0; i686; ; ) Cc: Hannes Magnusson , internals@lists.php.net, Rasmus Lerdorf , Felipe Pena , Christian Stocker , Andi Gutmans , Stanislav Malyshev References: <4899C4B4.3060902@liip.ch> <7f3ed2c30808080011l3c62d416k7fd9b4dd455df99e@mail.gmail.com> <489C6BBA.8030101@zend.com> In-Reply-To: <489C6BBA.8030101@zend.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200808081930.19404.arnaud.lb@gmail.com> Subject: Re: [PHP-DEV] include bug in 5.3 From: arnaud.lb@gmail.com (Arnaud Le Blanc) Hi, On Friday 08 August 2008 17:52:26 Dmitry Stogov wrote: > Hi, > > The attached patch is going to fix the problem. > It implements its own realpath() function, so we won't depend on system > anymore. It also improve realpath cache usage by caching intermediate > results. > > I tested it on Linux and Windows only and it seems to work without > problems. It breaks one test related to clearstatcache() function, but > this break is expected. > > Could you please test it. > Does it really fix the bug on FreeBSD? Yes, it fixes the bug on FreeBSD :) > > Thanks. Dmitry. > > Hannes Magnusson wrote: > > On Thu, Aug 7, 2008 at 22:37, Arnaud Le Blanc wrote: > >> virtual_file_ex() assumes that realpath() returns NULL when the file > >> does not exists. But BSD's realpath() will not return NULL if all > >> components *but the last* exist. So realpath(/foo/bar) will return > >> /foo/bar even if bar does not exists. > > > > And that behavior is intended, but is sadly overwritten in ZTS :( > > > > -Hannes Regards, Arnaud