Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39727
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.134.191 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=jgVSlyigRbGccaSiWVi5pUbTa3mE+oLeafCKEPbixnN97ZPtzw6/AS4IBXIQYTL/3T
         RI6yl4vUTMxpuLqm8HmqFYX3szhJtf+IjBAiKKiyBzXPIQaWvehuHKsy7nCpuJjlJTlt
         wEd3n5erq2xEvjMgkBPzmKPoc5XmfUVeYFvW4=
To: Johannes =?iso-8859-15?q?Schl=FCter?= <johannes@php.net>
Date: Thu, 7 Aug 2008 11:33:02 +0200
User-Agent: KMail/1.10.0 (Linux/2.6.26-noch; KDE/4.1.0; i686; ; )
Cc: internals@lists.php.net,
 jani.taskinen@iki.fi,
 Rasmus Lerdorf <rasmus@lerdorf.com>,
 Hannes Magnusson <hannes.magnusson@gmail.com>
References: <48997CC5.60709@lerdorf.com> <200808062101.00394.arnaud.lb@gmail.com> <1218066607.11642.6.camel@goldfinger.johannes.nop>
In-Reply-To: <1218066607.11642.6.camel@goldfinger.johannes.nop>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-ID: <200808071133.03539.arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] clearstatcache change
From: arnaud.lb@gmail.com (Arnaud Le Blanc)

On Thursday 07 August 2008 01:50:06 Johannes Schl=FCter wrote:
> On Wed, 2008-08-06 at 21:00 +0200, Arnaud Le Blanc wrote:
> > > > btw. I just noticed chroot() calls this
> > > > realpath_cache_clean()..intentional?
>
> I'd assume that, as /foo inside a chroot is different from /foo
> outside...
>
> >  Also some streams stuff uses the
> >
> > > > php_clear_stat_cache() func but those should propably use the
> > > > realpatch_cache_del() instead and not blow away whole cache?
> > >
> > > Yes, I think too.
> > > I added that to your patch:
> > > http://arnaud.lb.s3.amazonaws.com/clearstatcache_optional_params.patch
> > > :)
> > >
> > > It also adds the "filename" argument to
> > > clearstatcache([bool clear_realpath_cache[, filename]])
> >
> > I reply to myself, actually this may cause troubles to not clear the fu=
ll
> > cache in plain_wrapper.c :/ I updated the patch, just left the filename
> > argument to clearstatcache().
>
> If you fix the arginfo like Hannes it's, good. If the name of the second
> parameter in the proto ("filename") is the same as in the implementation
> ("pathname") it might even be a bit better :-)
>
> johanes

Commited :)=20