Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39720 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 25555 invoked from network); 6 Aug 2008 23:50:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Aug 2008 23:50:17 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.163 as permitted sender) X-PHP-List-Original-Sender: johannes@php.net X-Host-Fingerprint: 83.243.58.163 mail4.netbeat.de Received: from [83.243.58.163] ([83.243.58.163:39280] helo=mail4.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2C/72-29324-5B83A984 for ; Wed, 06 Aug 2008 19:50:16 -0400 Received: (qmail 9666 invoked by uid 507); 6 Aug 2008 23:50:10 -0000 Received: from ppp-82-135-94-145.dynamic.mnet-online.de (HELO ?192.168.1.101?) (postmaster%schlueters.de@82.135.94.145) by mail4.netbeat.de with ESMTPA; 6 Aug 2008 23:50:10 -0000 To: Arnaud Le Blanc Cc: internals@lists.php.net, jani.taskinen@iki.fi, Rasmus Lerdorf In-Reply-To: <200808062101.00394.arnaud.lb@gmail.com> References: <48997CC5.60709@lerdorf.com> <4899CEE9.5050904@sci.fi> <200808061956.58909.arnaud.lb@gmail.com> <200808062101.00394.arnaud.lb@gmail.com> Content-Type: text/plain Date: Thu, 07 Aug 2008 01:50:06 +0200 Message-ID: <1218066607.11642.6.camel@goldfinger.johannes.nop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] clearstatcache change From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=) On Wed, 2008-08-06 at 21:00 +0200, Arnaud Le Blanc wrote: > > > btw. I just noticed chroot() calls this > > > realpath_cache_clean()..intentional? I'd assume that, as /foo inside a chroot is different from /foo outside... > Also some streams stuff uses the > > > php_clear_stat_cache() func but those should propably use the > > > realpatch_cache_del() instead and not blow away whole cache? > > > > Yes, I think too. > > I added that to your patch: > > http://arnaud.lb.s3.amazonaws.com/clearstatcache_optional_params.patch :) > > > > It also adds the "filename" argument to > > clearstatcache([bool clear_realpath_cache[, filename]]) > > I reply to myself, actually this may cause troubles to not clear the full > cache in plain_wrapper.c :/ I updated the patch, just left the filename > argument to clearstatcache(). If you fix the arginfo like Hannes it's, good. If the name of the second parameter in the proto ("filename") is the same as in the implementation ("pathname") it might even be a bit better :-) johanes