Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39716
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.184 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=xfdaSBwmyIA5j2B8wZxePdi4Xw9bzQMobfA2oIXJveZW2tgGft2V6eujDk3x3P2I5y
         IqUwgvunzc6EdAnYhKks5WjRYwaOQSS990n4O9BHjzUcFmxVVJ7w2ymqqSEey8ncU8Ox
         LbNwVGJltOxN+PUsFtV9D3nOxe4QqWQWFxIR0=
Message-ID: <7f3ed2c30808061415l6767351fia39f533922527910@mail.gmail.com>
Date: Wed, 6 Aug 2008 23:15:57 +0200
To: "Arnaud Le Blanc" <arnaud.lb@gmail.com>
Cc: internals@lists.php.net, jani.taskinen@iki.fi, 
	"Rasmus Lerdorf" <rasmus@lerdorf.com>
In-Reply-To: <200808062101.00394.arnaud.lb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <48997CC5.60709@lerdorf.com> <4899CEE9.5050904@sci.fi>
	 <200808061956.58909.arnaud.lb@gmail.com>
	 <200808062101.00394.arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] clearstatcache change
From: hannes.magnusson@gmail.com ("Hannes Magnusson")

On Wed, Aug 6, 2008 at 21:00, Arnaud Le Blanc <arnaud.lb@gmail.com> wrote:
> On Wednesday 06 August 2008 19:56:58 Arnaud Le Blanc wrote:
>> Hi,
>>
>> On Wednesday 06 August 2008 18:18:49 Jani Taskinen wrote:
>> > Rasmus Lerdorf wrote:
>> > > I think we either need to make clearstatcache() not affect the realpath
>> > > cache, or we should add an optional argument to it to specify whether
>> > > or not the realpath cache should be cleared as well.
>> >
>> > See this: http://bugs.php.net/39367
>> >
>> > Considering some people seem to want to clear realpath cache as well, I'd
>> > make it an optional parameter which defaults to NOT clear realpath cache:
>> >
>> > clearstatchache(true); /* BOOM! realpath cache gone.. */
>> >
>> > btw. I just noticed chroot() calls this
>> > realpath_cache_clean()..intentional? Also some streams stuff uses the
>> > php_clear_stat_cache() func but those should propably use the
>> > realpatch_cache_del() instead and not blow away whole cache?
>>
>> Yes, I think too.
>> I added that to your patch:
>> http://arnaud.lb.s3.amazonaws.com/clearstatcache_optional_params.patch :)
>>
>> It also adds the "filename" argument to
>> clearstatcache([bool clear_realpath_cache[, filename]])
>
> I reply to myself, actually this may cause troubles to not clear the full
> cache in plain_wrapper.c :/ I updated the patch, just left the filename
> argument to clearstatcache().

Don't forget to update the arginfo

-Hannes