Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39713
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain phpdoc.de from 212.227.126.188 cause and error)
Message-ID: <4899F71D.8010306@phpdoc.de>
Date: Wed, 06 Aug 2008 21:10:21 +0200
User-Agent: Thunderbird 2.0.0.16 (Windows/20080708)
MIME-Version: 1.0
To: Stanislav Malyshev <stas@zend.com>
CC: 'PHP Internals' <internals@lists.php.net>
References: <4899D1F2.2060101@zend.com>
In-Reply-To: <4899D1F2.2060101@zend.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] mysql_set_charset
From: ulf.wendel@phpdoc.de (Ulf Wendel)

Stanislav Malyshev schrieb:
> I notice that mysql_set_charset function is not part of 5.3 tree and 
> it's test is marked as "usage not recommended". Could you explain what 
> is the reason for that? It's quite unusual to drop functions in later 
> versions, and if mysql_set_charset() has some problem we should note 
> that in the manual.

Hi Stas,

good find!

I think it has happened accidently in 5_3 at Revision 1.213.2.6.2.16.2.2 
when patching ext/mysql for mysqlnd some 10 months ago [1] . Its in 5_2 
and its in HEAD. Andrey is working on re-introducing it to ext/mysql in 
the 5_3 branch.

I don't recall why I added "usage not recommended" to the test. Let me 
check with Georg. He had some concerns on the function as far as I remember.

Ulf

[1] 
http://cvs.php.net/viewvc.cgi/php-src/ext/mysql/php_mysql.c?r1=1.213.2.6.2.16.2.1&r2=1.213.2.6.2.16.2.2