Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39708
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.198.228 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=iXArghclgpGotFIhjApta9RKhFAfZgzsycWJAOJDFEr8Ev2pWRFme8OWXCh+flLzHV
         xlIE9fLQ7o3nfVqgQJlfzeTc2x9vPyKeIT5pedjJzO3C6wavJ8jlVVDnzOX3v/LIhQ8o
         qMdz0XsToaG7ygCGwfMZtlRw1bDP6+egoFNeA=
To: internals@lists.php.net,
 jani.taskinen@iki.fi
Date: Wed, 6 Aug 2008 19:56:58 +0200
User-Agent: KMail/1.10.0 (Linux/2.6.26-noch; KDE/4.1.0; i686; ; )
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>
References: <48997CC5.60709@lerdorf.com> <4899CEE9.5050904@sci.fi>
In-Reply-To: <4899CEE9.5050904@sci.fi>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200808061956.58909.arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] clearstatcache change
From: arnaud.lb@gmail.com (Arnaud Le Blanc)

Hi,

On Wednesday 06 August 2008 18:18:49 Jani Taskinen wrote:
> Rasmus Lerdorf wrote:
> > I think we either need to make clearstatcache() not affect the realpath
> > cache, or we should add an optional argument to it to specify whether or
> > not the realpath cache should be cleared as well.
>
> See this: http://bugs.php.net/39367
>
> Considering some people seem to want to clear realpath cache as well, I'd
> make it an optional parameter which defaults to NOT clear realpath cache:
>
> clearstatchache(true); /* BOOM! realpath cache gone.. */
>
> btw. I just noticed chroot() calls this
> realpath_cache_clean()..intentional? Also some streams stuff uses the
> php_clear_stat_cache() func but those should propably use the
> realpatch_cache_del() instead and not blow away whole cache?

Yes, I think too.
I added that to your patch: 
http://arnaud.lb.s3.amazonaws.com/clearstatcache_optional_params.patch :) 

It also adds the "filename" argument to 
clearstatcache([bool clear_realpath_cache[, filename]])

>
> Here is a patch to add that optional parameter (for PHP_5_3):
>
> http://pecl.php.net/~jani/patches/clearstatcache_optional_param.patch
>
> --Jani