Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39691 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 16730 invoked from network); 6 Aug 2008 07:47:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Aug 2008 07:47:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.154 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 72.14.220.154 fg-out-1718.google.com Received: from [72.14.220.154] ([72.14.220.154:14606] helo=fg-out-1718.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BE/14-01880-40759984 for ; Wed, 06 Aug 2008 03:47:17 -0400 Received: by fg-out-1718.google.com with SMTP id 16so2221401fgg.23 for ; Wed, 06 Aug 2008 00:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=gU0MfCvdK0GT7es2tofRFPbnhTdRQ8Tl9T9CoZND1SE=; b=sIBd+Khw4r6ebalV1hHuOm0ItAyXOP8h14y7mjMoQkj1WpYQgdifUfppgMggMafhrt iSRFaw4qCAMS6ByN8y016S4t5gvy1ytUqpHS7ie7BGRDhNw+df3mBQq+Ax8HjlhM+rV3 porgakgpq+IEf/ViFLTRylw+TF9gYah1iVObE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=lpFVTf4te5rdt8wHUP9924rvnzqf66bpE1FNztfbjJ8l+Sff/m3N+MjfthM5RXuYc3 jMROVcq4MP2VTUC38EVrZZ9eL7gFw8iI35mvggWWGWGDihfo7oaZLs74+GQYex/6EaEg s8Vijx0VLv9mT3nNQlSI5jN3NGd4uhHB2jGH8= Received: by 10.103.49.7 with SMTP id b7mr1224923muk.104.1218008833799; Wed, 06 Aug 2008 00:47:13 -0700 (PDT) Received: by 10.103.248.20 with HTTP; Wed, 6 Aug 2008 00:47:13 -0700 (PDT) Message-ID: <7f3ed2c30808060047jb918049o8492b9c4bf58bd77@mail.gmail.com> Date: Wed, 6 Aug 2008 09:47:13 +0200 To: "Davey Shafik" Cc: "=?ISO-8859-1?Q?\"Johannes_Schl=FCter\"?=" , internals@lists.php.net In-Reply-To: <2A1FDF9D-4C69-433C-8187-6D3C8A1BA550@php.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <220AF877-747F-4BDB-8631-235B54ED2503@php.net> <7f3ed2c30808040049w7172205ey4ae460be4beabcee@mail.gmail.com> <1217847749.4175.27.camel@goldfinger.johannes.nop> <7f3ed2c30808040414y41f32ef6ka5a9396e027978d5@mail.gmail.com> <2A1FDF9D-4C69-433C-8187-6D3C8A1BA550@php.net> Subject: Re: [PHP-DEV] [PATCH] Alias stream_context_get_default() as stream_context_set_default() From: hannes.magnusson@gmail.com ("Hannes Magnusson") On Wed, Aug 6, 2008 at 06:24, Davey Shafik wrote: > OK, here's an attempt at a patch[1], I discussed it briefly with Johannes > and he felt some discussion was needed with regards to the return value. > > I personally seem some benefit to returning the "new" context; Johannes > wasn't sure that returning "true" might not be a better option in that we > cannot return the previous "value" like ini_set(). Why can't we? If there was a default context then return it, otherwise true/false.. Hmh. That could be confusing. I'm fine returning the new context :) > [1] http://pixelated-dreams.com/~davey/stream_context_set_default.patch The arginfo is wrong, the parameter is required, not optional. + parse_context_options(context, params TSRMLS_CC); params? Shouldn't this be options? :) -Hannes