Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39623
Return-Path: <johannes@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 24714 invoked from network); 4 Aug 2008 10:59:18 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 4 Aug 2008 10:59:18 -0000
Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.163 as permitted sender)
X-PHP-List-Original-Sender: johannes@php.net
X-Host-Fingerprint: 83.243.58.163 mail4.netbeat.de  
Received: from [83.243.58.163] ([83.243.58.163:56164] helo=mail4.netbeat.de)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id AB/1F-46562-501E6984 for <internals@lists.php.net>; Mon, 04 Aug 2008 06:59:18 -0400
Received: (qmail 18832 invoked by uid 507); 4 Aug 2008 10:59:12 -0000
Received: from ppp-82-135-94-222.dynamic.mnet-online.de (HELO ?192.168.1.101?) (postmaster%schlueters.de@82.135.94.222)
  by mail4.netbeat.de with ESMTPA; 4 Aug 2008 10:59:12 -0000
To: Christian Seiler <chris_se@gmx.net>
Cc: Marcus Boerger <helly@php.net>, Dmitry Stogov <dmitry@zend.com>, php-dev List <internals@lists.php.net>
In-Reply-To: <4896B0B4.2090801@zend.com>
References: <48886651.80407@gmx.net> <4889F43D.8030609@gmx.net>
	 <4896B0B4.2090801@zend.com>
Content-Type: text/plain
Date: Mon, 04 Aug 2008 12:59:13 +0200
Message-ID: <1217847553.4175.23.camel@goldfinger.johannes.nop>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) 
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Closures and reflection improvements
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Christian,

On Mon, 2008-08-04 at 11:33 +0400, Dmitry Stogov wrote:
> >> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch 
> >>
> >> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-6.patch 
> > 

without applying and testing the patch:

-	zend_hash_apply_with_arguments(&ce->function_table TSRMLS_CC, (apply_func_args_t) _addmethod, 3, &ce, return_value, filter);
+	zend_hash_apply_with_arguments(&ce->function_table TSRMLS_CC, (apply_func_args_t) _addmethod, 3, &ce, return_value, filter, intern->obj);

that looks a bit strange, probably you want 4 instead of 3 now?

johannes