Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39523
Return-Path: <helly@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 89655 invoked from network); 1 Aug 2008 06:25:04 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 1 Aug 2008 06:25:04 -0000
Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
X-PHP-List-Original-Sender: helly@php.net
X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6
Received: from [85.214.94.56] ([85.214.94.56:35784] helo=h1149922.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id F8/26-37723-D3CA2984 for <internals@lists.php.net>; Fri, 01 Aug 2008 02:25:04 -0400
Received: from localhost (h1149922.serverkompetenz.net [85.214.94.56])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by h1149922.serverkompetenz.net (Postfix) with ESMTP id 1083911DB81;
	Fri,  1 Aug 2008 08:24:57 +0200 (CEST)
Date: Fri, 1 Aug 2008 08:24:59 +0200
Reply-To: Marcus Boerger <helly@php.net>
X-Priority: 3 (Normal)
Message-ID: <1921155132.20080801082459@marcus-boerger.de>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
CC: PHP Developers Mailing List <internals@lists.php.net>
In-Reply-To: <489076D3.8000106@lerdorf.com>
References: <489076D3.8000106@lerdorf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] PEAR Build fix
From: helly@php.net (Marcus Boerger)

Hello Rasmus,

Wednesday, July 30, 2008, 4:12:35 PM, you wrote:

> Could someone please fix this:

> Generating phar.php
> Generating phar.phar
> Pear package PHP_Archive found: API Version: 1.0.0 (stable).
> Pear package PHP_Archive or Archive.php class file not found.
> clicommand.inc
> directorygraphiterator.inc
> directorytreeiterator.inc
> invertedregexiterator.inc
> pharcommand.inc
> phar.inc

> Build complete.
> Don't forget to run 'make test'.

> The problem is that in phar.php it does a

>    pear list-files PHP_Archive

> This outputs a bunch of filenames ending with:

> test /usr/local/lib/php/test/PHP_Archive/tests/test_require.php
> test /usr/local/lib/php/test/PHP_Archive/tests/test_tar.tar
> test /usr/local/lib/php/test/PHP_Archive/tests/twophars.phpt
> php  /usr/local/lib/php/PHP/Archive.php

> in phar.php the regex to check if Archive.php exists looks like this:

> if (preg_match(",^php[ \t]+([^ 
> \t].*pear[\\\\/]PHP[\\\\/]Archive.php)$,", $ent, $matches)) {

> which is obviously not going to match that last Archive.php line.  So, 
> two fixes here.  First, fix the error message to more accurately 
> describe what is going on.  And second, assuming 
> /usr/local/lib/php/PHP/Archive.php is the right file here, fix the regex.

  thanks! & fixed.

marcus





Best regards,
 Marcus