Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39518
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.163 as permitted sender)
To: Matt Wilmas <php_lists@realplain.com>
Cc: internals@lists.php.net, Lukas Kahwe Smith <mls@pooteeweet.org>
In-Reply-To: <1217527569.5408.65.camel@goldfinger.johannes.nop>
References: <01b401c8ec13$28cd3510$0201a8c0@pc1>
	 <1217505976.5408.34.camel@goldfinger.johannes.nop>
	 <01fc01c8f32d$3f42a7f0$0201a8c0@pc1>
	 <1217527569.5408.65.camel@goldfinger.johannes.nop>
Content-Type: text/plain; charset=utf-8
Date: Fri, 01 Aug 2008 00:21:45 +0200
Message-ID: <1217542905.4168.1.camel@goldfinger.johannes.nop>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] New functions: array_replace[_recursive]
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Matt,

On Thu, 2008-07-31 at 20:06 +0200, Johannes Schlüter wrote:
> On Thu, 2008-07-31 at 11:48 -0500, Matt Wilmas wrote:
> > Ugh, I hate that reference/recursion stuff!  I have a hard time following
> > what's happening, and am not sure how some of those checks, etc. even work
> > in php_array_merge() (which I was working from). :-/  I tried changing a few
> > parts, and unfortunately couldn't fix it.  I will look at it further when I
> > have some more time, and will of course let you know if it's fixed.  Sorry.
> > :-(
> 
> I think I found a thing: you're iterating over src and src_entry, but
> doing the recursion check using Z_ARRVAL_PP(dest_entry)->nApplyCount, I
> didn't test it (need food first) but should do that with src_entry.

FYI: that assumption seems to be correct and I committed it including
the fix :-)

johannes