Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39512
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain realplain.com from 209.235.152.153 cause and error)
Message-ID: <020e01c8f32e$a82a9fb0$0201a8c0@pc1>
To: <internals@lists.php.net>, "Dmitry Stogov" <dmitry@zend.com>
References: <00ea01c8a160$2edd8160$0201a8c0@pc1> <016c01c8eccd$e28cfac0$0201a8c0@pc1> <488835D0.1040005@zend.com> <00e501c8ed77$3498cf20$0201a8c0@pc1> <48889901.8000008@zend.com> <015101c8f306$34c358f0$0201a8c0@pc1> <4891CC46.2020208@zend.com>
Date: Thu, 31 Jul 2008 11:58:27 -0500
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] No runtime fetching of built-in global constants
From: php_lists@realplain.com ("Matt Wilmas")

Hi Dmitry,

Do you know that with your changes, no substitution will happen in a
namespace even when using :: prefix? :-/  (That's what I would do when I
know it's global, for optimization.)  Or is that what you meant by "not so
optimal?"


- Matt


----- Original Message -----
From: "Dmitry Stogov"
Sent: Thursday, July 31, 2008

> Thanks Matt. I committed near the same patch.
> It's not so optimal, but little bit more clear.
>
> Thanks. Dmitry.
>
> Matt Wilmas wrote:
> > Hi Dmitry,
> >
> > For the behavior change that I mentioned in the other thread, with this
> > code:
> >
> > function foo() {
> >     static $a = -PHP_INT_MAX;
> > }
> >
> > Which could work sometimes, and sometimes not (if in a namespace or
> > ZEND_COMPILE_NO_CONSTANT_SUBSTITUTION is set).  I changed things so that
> > there is no substitution of constants (except with CT_SUBST flag, like
> > always) for compile time constants (ZEND_CT mode).  They don't create a
> > FETCH_CONSTANT opcode anyway. :-)
> >
> > Another thing I realized wasn't getting optimized (runtime constants),
which
> > can be, is with:
> >
> > namespace foo;
> > $a = ::PHP_INT_MAX;  // :: for global scope
> >
> > So the patch allows substitution there as well.
> >
> > http://realplain.com/php/ct_const_fixes.diff
> > http://realplain.com/php/ct_const_fixes_5_3.diff