Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39499
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.163 as permitted sender)
To: Matt Wilmas <php_lists@realplain.com>
Cc: internals@lists.php.net, Lukas Kahwe Smith <mls@pooteeweet.org>
In-Reply-To: <01b401c8ec13$28cd3510$0201a8c0@pc1>
References: <01b401c8ec13$28cd3510$0201a8c0@pc1>
Content-Type: text/plain
Date: Thu, 31 Jul 2008 14:06:16 +0200
Message-ID: <1217505976.5408.34.camel@goldfinger.johannes.nop>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] New functions: array_replace[_recursive]
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Matt,

On Tue, 2008-07-22 at 10:52 -0500, Matt Wilmas wrote:
> Adding these two array functions has been on the TODO for a while, 

The patch can quite easily be tricked into an endless recursion of
php_array_replace_recursive() calls which will segfault:

$ php -r '$a = array(); $a[] = &$a; $b = array(); $b[] = &$b;
array_replace_recursive($a, $b);'
Segmentation fault

Some other cases were covered by PHP's recursion detection:

$ php -r '$a = array(); $a[1] = &$a; $b = array(); $b[2] = &$b;
array_replace_recursive($a, $b, array(&$a, &$b), array(&$b, &$a));'

Warning: array_replace_recursive(): recursion detected in Command line
code on line 1

Can you try to add a detection for the first case?

johannes