Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39463
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 204.11.219.139 cause and error)
Message-ID: <489076D3.8000106@lerdorf.com>
Date: Wed, 30 Jul 2008 16:12:35 +0200
User-Agent: Thunderbird/3.0a2pre (Macintosh; 2008071516)
MIME-Version: 1.0
To: PHP Developers Mailing List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: PEAR Build fix
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Could someone please fix this:

Generating phar.php
Generating phar.phar
Pear package PHP_Archive found: API Version: 1.0.0 (stable).
Pear package PHP_Archive or Archive.php class file not found.
clicommand.inc
directorygraphiterator.inc
directorytreeiterator.inc
invertedregexiterator.inc
pharcommand.inc
phar.inc

Build complete.
Don't forget to run 'make test'.

The problem is that in phar.php it does a

   pear list-files PHP_Archive

This outputs a bunch of filenames ending with:

test /usr/local/lib/php/test/PHP_Archive/tests/test_require.php
test /usr/local/lib/php/test/PHP_Archive/tests/test_tar.tar
test /usr/local/lib/php/test/PHP_Archive/tests/twophars.phpt
php  /usr/local/lib/php/PHP/Archive.php

in phar.php the regex to check if Archive.php exists looks like this:

if (preg_match(",^php[ \t]+([^ 
\t].*pear[\\\\/]PHP[\\\\/]Archive.php)$,", $ent, $matches)) {

which is obviously not going to match that last Archive.php line.  So, 
two fixes here.  First, fix the error message to more accurately 
describe what is going on.  And second, assuming 
/usr/local/lib/php/PHP/Archive.php is the right file here, fix the regex.

-Rasmus