Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39418 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37159 invoked from network); 28 Jul 2008 20:48:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jul 2008 20:48:52 -0000 Authentication-Results: pb1.pair.com smtp.mail=nunoplopes@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=nunoplopes@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.191 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: nunoplopes@gmail.com X-Host-Fingerprint: 209.85.128.191 fk-out-0910.google.com Received: from [209.85.128.191] ([209.85.128.191:3600] helo=fk-out-0910.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B9/98-24886-3B03E884 for ; Mon, 28 Jul 2008 16:48:51 -0400 Received: by fk-out-0910.google.com with SMTP id 18so3588778fks.7 for ; Mon, 28 Jul 2008 13:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=Vp+vjDdBH9LkwHsWpR2G3YFL+5JWMK+s8/UeX/fqF1g=; b=uEzqSccX5DxlqYm4UWgyUn2pvlFwh9aGcS+sXOMHRfZySTi70FLbxNznIn1dZweH4E oYM5n9yxLzPG8Z9xDmQvfl87i6iGBzkE4Gthzxirz8e4kCJAubm4LOYVxx4Jy6YkYQ1J uKaeN5PY7UypEe0k63cwl7k8vMMN79dbUmNyQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=g3RJkVtdkbbv0y14/WXQDXGcJZ/zuinE9UxktiHfZkiymVzze3X81hx22aZoxxKDs+ 1Vhf/1NzYVNo6cXN+3NoMYZFv8z3RTK6ZNTqYsQrpevQDz8+UfniJaGjAlN+6wi/wIBx l6zyXwYbnvggndeafC7Ca8d5N4vftYHZXGET0= Received: by 10.125.130.1 with SMTP id h1mr305685mkn.115.1217278128153; Mon, 28 Jul 2008 13:48:48 -0700 (PDT) Received: by 10.125.92.3 with HTTP; Mon, 28 Jul 2008 13:48:48 -0700 (PDT) Message-ID: <7ca798440807281348t719246c7k4bf6d936168a43a6@mail.gmail.com> Date: Mon, 28 Jul 2008 21:48:48 +0100 Sender: nunoplopes@gmail.com To: "Stanislav Malyshev" Cc: "PHP Internals" In-Reply-To: <488E204C.9010809@zend.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <488E204C.9010809@zend.com> X-Google-Sender-Auth: beb310b71eec6cae Subject: Re: [PHP-DEV] [Fwd: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_strtod.c] From: nlopess@php.net ("Nuno Lopes") I already expressed my opinion.. If you know what's the buggy gcc version, just fail at configure time if it's present. Nuno On Mon, Jul 28, 2008 at 20:38, Stanislav Malyshev wrote: > Hi! > > I wanted to ask people here about this patch. See history in > http://bugs.php.net/bug.php?id=43487 but basically there's some gcc out > there that miscompiles zend_strtod.c. We can fix it, probably at some > marginal performance cost, but the question is - should we? It's pre-release > compiler and not in the latest version. > > So can anyone using non-prerelease gcc of any recent version - or non-gcc > compiler even - reproduce this? Should we keep the change or just tell > people "use working compiler"? > > -------- Original Message -------- > Subject: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_strtod.c > Date: Sun, 27 Jul 2008 11:29:59 -0000 > From: Dmitry Stogov > To: zend-engine-cvs@lists.php.net > > dmitry Sun Jul 27 11:29:59 2008 UTC > > Modified files: > /ZendEngine2 zend_strtod.c > Log: > Fix for bug #43487 (Wrong conversion of float to string) > > > http://cvs.php.net/viewvc.cgi/ZendEngine2/zend_strtod.c?r1=1.37&r2=1.38&diff_format=u > Index: ZendEngine2/zend_strtod.c > diff -u ZendEngine2/zend_strtod.c:1.37 ZendEngine2/zend_strtod.c:1.38 > --- ZendEngine2/zend_strtod.c:1.37 Wed Mar 26 14:23:02 2008 > +++ ZendEngine2/zend_strtod.c Sun Jul 27 11:29:59 2008 > @@ -89,7 +89,7 @@ > * directly -- and assumed always to succeed. > */ > > -/* $Id: zend_strtod.c,v 1.37 2008/03/26 14:23:02 scottmac Exp $ */ > +/* $Id: zend_strtod.c,v 1.38 2008/07/27 11:29:59 dmitry Exp $ */ > > #include > #include > @@ -991,9 +991,9 @@ > > static double ulp (double _x) /* {{{ */ > { > - _double x; > + volatile _double x; > register Long L; > - _double a; > + volatile _double a; > > value(x) = _x; > L = (word0(x) & Exp_mask) - (P-1)*Exp_msk1; > @@ -1035,7 +1035,7 @@ > { > ULong *xa, *xa0, w, y, z; > int k; > - _double d; > + volatile _double d; > #ifdef VAX > ULong d0, d1; > #else > @@ -1101,7 +1101,7 @@ > Bigint *b; > int de, i, k; > ULong *x, y, z; > - _double d; > + volatile _double d; > #ifdef VAX > ULong d0, d1; > #endif > @@ -1223,7 +1223,7 @@ > > static double ratio (Bigint *a, Bigint *b) /* {{{ */ > { > - _double da, db; > + volatile _double da, db; > int k, ka, kb; > > value(da) = b2d(a, &ka); > @@ -1492,7 +1492,7 @@ > Bigint *b, *b1, *delta, *mlo, *mhi, *S, *tmp; > double ds; > char *s, *s0; > - _double d, d2, eps; > + volatile _double d, d2, eps; > > value(d) = _d; > > @@ -2056,7 +2056,7 @@ > e, e1, esign, i, j, k, nd, nd0, nf, nz, nz0, sign; > CONST char *s, *s0, *s1; > double aadj, aadj1, adj; > - _double rv, rv0; > + volatile _double rv, rv0; > Long L; > ULong y, z; > Bigint *bb, *bb1, *bd, *bd0, *bs, *delta, *tmp; > > > > -- > Zend Engine CVS Mailing List (http://cvs.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > > -- > Stanislav Malyshev, Zend Software Architect > stas@zend.com http://www.zend.com/ > (408)253-8829 MSN: stas@zend.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php