Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39339 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 85219 invoked from network); 25 Jul 2008 21:02:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Jul 2008 21:02:00 -0000 Authentication-Results: pb1.pair.com smtp.mail=mls@pooteeweet.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=mls@pooteeweet.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 88.198.8.16 cause and error) X-PHP-List-Original-Sender: mls@pooteeweet.org X-Host-Fingerprint: 88.198.8.16 bigtime.backendmedia.com Linux 2.6 Received: from [88.198.8.16] ([88.198.8.16:34259] helo=bigtime.backendmedia.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 79/83-00520-54F3A884 for ; Fri, 25 Jul 2008 17:01:58 -0400 Received: from localhost (unknown [127.0.0.1]) by bigtime.backendmedia.com (Postfix) with ESMTP id 4A0F21EBC01B; Fri, 25 Jul 2008 21:02:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at backendmedia.com Received: from bigtime.backendmedia.com ([127.0.0.1]) by localhost (bigtime.backendmedia.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZX5-94aIK9He; Fri, 25 Jul 2008 23:01:59 +0200 (CEST) Received: from [192.168.0.151] (77-57-23-243.dclient.hispeed.ch [77.57.23.243]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mls@pooteeweet.org) by bigtime.backendmedia.com (Postfix) with ESMTP id BC0AD1EBC019; Fri, 25 Jul 2008 23:01:59 +0200 (CEST) To: Marcus Boerger In-Reply-To: <1016246995.20080725205642@marcus-boerger.de> X-Priority: 3 (Normal) References: <48886651.80407@gmx.net> <4889F43D.8030609@gmx.net> <1016246995.20080725205642@marcus-boerger.de> Message-ID: <989F99AA-9A0B-41EE-B440-125A438E7DDA@pooteeweet.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v928.1) Date: Fri, 25 Jul 2008 23:00:18 +0200 Cc: Christian Seiler , php-dev List X-Mailer: Apple Mail (2.928.1) Subject: Re: [PHP-DEV] [PATCH] Closures and reflection improvements From: mls@pooteeweet.org (Lukas Kahwe Smith) On 25.07.2008, at 20:56, Marcus Boerger wrote: > Hello Christian, > > patch looks fine and should go in. > > do you think ReflectionMethod::__construct implementation could be > done > using parameterparsing 'f' rather than the spcial case 'o'? > Unfortunately > we would still need the zs version unless we add another 'F' parameter > parsing that allows this two parameter case as well. > > marcus > > Friday, July 25, 2008, 5:41:49 PM, you wrote: > >> Hi, > >>> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch >>> >>> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-6.patch if this isnt commited yet .. could someone handle this ASAP? Lukas Kahwe Smith mls@pooteeweet.org