Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39334
Return-Path: <chris_se@gmx.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 44105 invoked from network); 25 Jul 2008 19:02:40 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 25 Jul 2008 19:02:40 -0000
Authentication-Results: pb1.pair.com smtp.mail=chris_se@gmx.net; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=chris_se@gmx.net; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmx.net designates 213.165.64.20 as permitted sender)
X-PHP-List-Original-Sender: chris_se@gmx.net
X-Host-Fingerprint: 213.165.64.20 mail.gmx.net  
Received: from [213.165.64.20] ([213.165.64.20:33681] helo=mail.gmx.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BD/F4-22699-F432A884 for <internals@lists.php.net>; Fri, 25 Jul 2008 15:02:40 -0400
Received: (qmail invoked by alias); 25 Jul 2008 19:02:36 -0000
Received: from p54A161D6.dip.t-dialin.net (EHLO chris-se.dyndns.org) [84.161.97.214]
  by mail.gmx.net (mp065) with SMTP; 25 Jul 2008 21:02:36 +0200
X-Authenticated: #186999
X-Provags-ID: V01U2FsdGVkX1+2Yq8lm+y2nre+V5axEaMLV2sb+lSZlrelzMgHKb
	WITWiV0wJM8Gby
Received: from [192.168.100.13] (cobalt.seiler.lan [192.168.100.13])
	by chris-se.dyndns.org (Postfix) with ESMTP id E5C1E1B138;
	Fri, 25 Jul 2008 20:29:43 +0200 (CEST)
Message-ID: <488A22F9.2070409@gmx.net>
Date: Fri, 25 Jul 2008 21:01:13 +0200
User-Agent: Thunderbird 2.0.0.16 (X11/20080707)
MIME-Version: 1.0
To: Marcus Boerger <helly@php.net>
CC: php-dev List <internals@lists.php.net>
References: <48886651.80407@gmx.net> <4889F43D.8030609@gmx.net> <1016246995.20080725205642@marcus-boerger.de>
In-Reply-To: <1016246995.20080725205642@marcus-boerger.de>
X-Enigmail-Version: 0.95.6
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
X-FuHaFi: 0.79
Subject: Re: [PHP-DEV] [PATCH] Closures and reflection improvements
From: chris_se@gmx.net (Christian Seiler)

Hi Marcus,

>   patch looks fine and should go in.

Thanks.

> 
>   do you think ReflectionMethod::__construct implementation could be done
> using parameterparsing 'f' rather than the spcial case 'o'?

The Problem with 'f' is that it will accept every callback, even normal
functions, so that would kind of break the idea of having
ReflectionMethod different than ReflectionFunction.

So in my eyes, using 'o' for now is the sanest approach.

Regards,
Christian