Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39333
Return-Path: <helly@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 40610 invoked from network); 25 Jul 2008 18:56:52 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 25 Jul 2008 18:56:52 -0000
Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender)
X-PHP-List-Original-Sender: helly@php.net
X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6
Received: from [85.214.94.56] ([85.214.94.56:56057] helo=h1149922.serverkompetenz.net)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BF/24-22699-3F12A884 for <internals@lists.php.net>; Fri, 25 Jul 2008 14:56:52 -0400
Received: from MBOERGER-ZRH (ip131.fa1-0-1.occ.iinet.com [198.145.32.131])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by h1149922.serverkompetenz.net (Postfix) with ESMTP id A13FE11EFF7;
	Fri, 25 Jul 2008 20:56:48 +0200 (CEST)
Date: Fri, 25 Jul 2008 20:56:42 +0200
Reply-To: Marcus Boerger <helly@php.net>
X-Priority: 3 (Normal)
Message-ID: <1016246995.20080725205642@marcus-boerger.de>
To: Christian Seiler <chris_se@gmx.net>
CC: php-dev List <internals@lists.php.net>
In-Reply-To: <4889F43D.8030609@gmx.net>
References: <48886651.80407@gmx.net> <4889F43D.8030609@gmx.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [PATCH] Closures and reflection improvements
From: helly@php.net (Marcus Boerger)

Hello Christian,

  patch looks fine and should go in.

  do you think ReflectionMethod::__construct implementation could be done
using parameterparsing 'f' rather than the spcial case 'o'? Unfortunately
we would still need the zs version unless we add another 'F' parameter
parsing that allows this two parameter case as well.

marcus

Friday, July 25, 2008, 5:41:49 PM, you wrote:

> Hi,

>> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-5.3.patch 
>> 
>> http://www.christian-seiler.de/temp/php/2008-07-24-reflection/reflection-closure-fixes-6.patch 

> The last CVS commit for apply_func_t and TSRMLS_CC conflicted with the
> patches, I merged the conflicting line manually and reuploaded the
> patches to the same location.

> Regards,
> Christian




Best regards,
 Marcus