Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39321
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 72.14.220.152 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=n25i+KHh8qRnQp5QJQmi3XwOP7uM+ZWT6ldtbsYsV5O9I5cZe0SWWQydyaESvsHuzX
         yfoOUOiP21yFD0wjSb50JuheIAiVidSN5ivrd/lGjmEQFi66L0Re4KmwpMev2pURfwbt
         fmB86h7bABKYMqgW6XSi5JJBoSu4QgfHM1Zj8=
Message-ID: <7f3ed2c30807250353g6fb37d8kc6432634173427a6@mail.gmail.com>
Date: Fri, 25 Jul 2008 12:53:36 +0200
To: "Noah Fontes" <noah.fontes@bitextender.com>
Cc: "=?ISO-8859-1?Q?David_Z=FClke?=" <david.zuelke@bitextender.com>, 
	internals@lists.php.net
In-Reply-To: <48876D27.6030407@bitextender.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <4885E513.6080702@bitextender.com> <48864FA5.6050104@zend.com>
	 <B31EBBD3-6B33-4BEE-8997-E09D5293053B@bitextender.com>
	 <48876D27.6030407@bitextender.com>
Subject: Re: [PHP-DEV] Patch for HTTP successful status codes
From: hannes.magnusson@gmail.com ("Hannes Magnusson")

On Wed, Jul 23, 2008 at 19:40, Noah Fontes <noah.fontes@bitextender.com> wr=
ote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> David Z=FClke wrote:
>> Yeah. We discussed that quite a while back when I sent over the
>> "ignore_errors" options patch-like thing in November:
>> http://thread.gmane.org/gmane.comp.php.devel/46003
>>
>> I think we should do it.
>>
>> But what about other 3xx redirect codes? How are those handled?
>
> I think PHP implicitly follows any Location headers it can. That's
> probably not the right behavior, but for an automated process it's not ba=
d.
>
> I think that 3xx status codes, if they appear without a Location header,
> should also probably not throw errors. They could provide valuable
> information about the status of a page (particularly 304 Not Modified),
> so I've updated the patch:
>
> http://cynigram.com/~nfontes/http_fopen_wrapper.patch
>
> BTW, any chance this could be rolled into 5.3? I think the BC break is
> pretty non-notable, and it would be nice to stop throwing errors for
> successful responses.

I think changing all 3xx status codes to be success is a slightly more
bc break then you think.

A simple example:
I do a file_get_contents() request. Store it in a local buffer.
I do a second file_get_contents(), get a error (304) back, print out my buf=
fer.

Now, in 5.3.0 the 304 is treated as success so I naturally discard my
buffer and print the results of the new request... Whooopsy, there was
no data :(

-Hannes