Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39279 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 58107 invoked from network); 24 Jul 2008 18:43:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Jul 2008 18:43:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6 Received: from [85.214.94.56] ([85.214.94.56:44971] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B0/0E-22699-55DC8884 for ; Thu, 24 Jul 2008 14:43:33 -0400 Received: from MBOERGER-ZRH (ip131.fa1-0-1.occ.iinet.com [198.145.32.131]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id B5AAE11D027; Thu, 24 Jul 2008 20:43:29 +0200 (CEST) Date: Thu, 24 Jul 2008 20:43:25 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1363388964.20080724204325@marcus-boerger.de> To: Felipe Pena CC: Marcus Boerger , Lukas Kahwe Smith , PHP Developers Mailing List In-Reply-To: <1216912084.5398.2.camel@felipe> References: <161BC537-BBB8-4B73-B573-4BBA080CF743@pooteeweet.org> <1736835338.20080723185258@marcus-boerger.de> <1216912084.5398.2.camel@felipe> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] 5.3 feature freeze rapidly approaching From: helly@php.net (Marcus Boerger) Hello Felipe, awesome!!!! Just commit. marcus Thursday, July 24, 2008, 5:08:03 PM, you wrote: > Em Qua, 2008-07-23 às 18:52 +0200, Marcus Boerger escreveu: >> And then there are these: >> >> - should we finally change: >> typedef int (*apply_func_args_t)(void *pDest, int num_args, va_list args, zend_hash_key *hash_key); >> to >> typedef int (*apply_func_args_t)(void *pDest TSRMLS_DC, int num_args, va_list args, zend_hash_key *hash_key); >> so that we can drop a bunch of TSRMLS_FETCH()'es. > Would it be like that? > http://felipe.ath.cx/diff/zend_hash_apply_with_arguments.diff > -- > Regards, > Felipe Pena. Best regards, Marcus