Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39240 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70699 invoked from network); 23 Jul 2008 17:41:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Jul 2008 17:41:07 -0000 Authentication-Results: pb1.pair.com smtp.mail=nfontes@cynigram.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=nfontes@cynigram.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain cynigram.com designates 72.14.220.159 as permitted sender) X-PHP-List-Original-Sender: nfontes@cynigram.com X-Host-Fingerprint: 72.14.220.159 fg-out-1718.google.com Received: from [72.14.220.159] ([72.14.220.159:44375] helo=fg-out-1718.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 91/4D-12534-23D67884 for ; Wed, 23 Jul 2008 13:41:06 -0400 Received: by fg-out-1718.google.com with SMTP id 16so1592780fgg.23 for ; Wed, 23 Jul 2008 10:41:03 -0700 (PDT) Received: by 10.86.82.6 with SMTP id f6mr296434fgb.73.1216834859358; Wed, 23 Jul 2008 10:40:59 -0700 (PDT) Received: from ?10.224.251.3? ( [85.183.90.3]) by mx.google.com with ESMTPS id 4sm3387501fge.5.2008.07.23.10.40.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 23 Jul 2008 10:40:58 -0700 (PDT) Message-ID: <48876D27.6030407@bitextender.com> Date: Wed, 23 Jul 2008 19:40:55 +0200 Organization: Bitextender GmbH User-Agent: Mozilla-Thunderbird 2.0.0.14 (X11/20080509) MIME-Version: 1.0 To: =?UTF-8?B?RGF2aWQgWsO8bGtl?= CC: internals@lists.php.net References: <4885E513.6080702@bitextender.com> <48864FA5.6050104@zend.com> In-Reply-To: X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: Noah Fontes Subject: Re: [PHP-DEV] Patch for HTTP successful status codes From: noah.fontes@bitextender.com (Noah Fontes) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 David Zülke wrote: > Yeah. We discussed that quite a while back when I sent over the > "ignore_errors" options patch-like thing in November: > http://thread.gmane.org/gmane.comp.php.devel/46003 > > I think we should do it. > > But what about other 3xx redirect codes? How are those handled? I think PHP implicitly follows any Location headers it can. That's probably not the right behavior, but for an automated process it's not bad. I think that 3xx status codes, if they appear without a Location header, should also probably not throw errors. They could provide valuable information about the status of a page (particularly 304 Not Modified), so I've updated the patch: http://cynigram.com/~nfontes/http_fopen_wrapper.patch BTW, any chance this could be rolled into 5.3? I think the BC break is pretty non-notable, and it would be nice to stop throwing errors for successful responses. Regards, Noah - -- Noah Fontes Bitextender http://www.bitextender.com/ Phone: +1 919 349 9826 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFIh20nhitK+HuUQJQRAqipAJ9pndnS4K4L5GtPzoYsEguYQSgSXwCfb6yC YnohwjT8KYCiADQehg4Jm2A= =UzO8 -----END PGP SIGNATURE-----