Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:39211
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 64.233.182.189 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=G6tAZPinRakQ6bZM1mwR0mY+9GZ5nT7wdECG5BiTCXGXzDSsZ5hxSFmi4CKVXmSfi6
         TdT6Gmcty4fuDVYBqJgG+DHtF1FdGvmKUKtZQR9efsO0pycpo+/ueCap55u9DypI1ess
         nXnBP683mcSknYSQ9IBeV/rtCdyb6nyPj/SbA=
To: Marcus Boerger <helly@php.net>
Date: Wed, 23 Jul 2008 08:36:53 +0200
User-Agent: KMail/1.9.9
Cc: "internals" <internals@lists.php.net>,
 Etienne Kneuss <colder@php.net>
References: <200807081549.36758.arnaud.lb@gmail.com> <200807221123.47349.arnaud.lb@gmail.com> <12110462146.20080723011614@marcus-boerger.de>
In-Reply-To: <12110462146.20080723011614@marcus-boerger.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200807230836.54055.arnaud.lb@gmail.com>
Subject: Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation
From: arnaud.lb@gmail.com ("Arnaud Le Blanc")

Hello Marcus,

On Wednesday 23 July 2008 01:16:14 Marcus Boerger wrote:
> Hello Arnaud,
> 
> Tuesday, July 22, 2008, 11:23:47 AM, you wrote:
> 
> > Hello,
> 
> >> > Care to look into the MultipleIterator next?
> >> 
> 
> > That's done, for 5_3 [1] and HEAD [2].
> > And a test [3][4] covering mostly all the cases.
> 
> > [1] http://arnaud.lb.s3.amazonaws.com/MultipleIterator_5_3.patch
> > [2] http://arnaud.lb.s3.amazonaws.com/MultipleIterator_HEAD.patch
> > [3] http://arnaud.lb.s3.amazonaws.com/multiple_iterator_001_5_3.phpt
> > [4] http://arnaud.lb.s3.amazonaws.com/multiple_iterator_001_HEAD.phpt
> 
> Great work once more. I just moved the stuff all into spl_observer.c to
> avoid increasing the amount of stuff that gets exported in the headers.
> I also did a few minor tweaks and cleanups, nothing important though.
> 
> - setFlags parses directly into &intern->flags which is a long for that
>   reason
> - added !EG(exception) for the loops, though I have another patch that will
>   make exception handling better
> 
> I've also upgraded you, you've got php-src access now, use it wisely :-)

Thanks :) I will try to not break everything ;) 

I did not found anything about "Spl(Array|Index|Member)Reference" on the TODO, 
are there any discussion on that ?

Regards,

Arnaud