Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:39207 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50588 invoked from network); 22 Jul 2008 23:16:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Jul 2008 23:16:22 -0000 Authentication-Results: pb1.pair.com smtp.mail=helly@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=helly@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 85.214.94.56 as permitted sender) X-PHP-List-Original-Sender: helly@php.net X-Host-Fingerprint: 85.214.94.56 aixcept.net Linux 2.6 Received: from [85.214.94.56] ([85.214.94.56:35369] helo=h1149922.serverkompetenz.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id D0/D1-41758-54A66884 for ; Tue, 22 Jul 2008 19:16:21 -0400 Received: from MBOERGER-ZRH (ip131.fa1-0-1.occ.iinet.com [198.145.32.131]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by h1149922.serverkompetenz.net (Postfix) with ESMTP id 63C8A11DCB3; Wed, 23 Jul 2008 01:16:17 +0200 (CEST) Date: Wed, 23 Jul 2008 01:16:14 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <12110462146.20080723011614@marcus-boerger.de> To: "Arnaud Le Blanc" CC: Marcus Boerger , "internals" , Etienne Kneuss In-Reply-To: <200807221123.47349.arnaud.lb@gmail.com> References: <200807081549.36758.arnaud.lb@gmail.com> <1657130941.20080719175740@marcus-boerger.de> <200807200520.31258.arnaud.lb@gmail.com> <200807221123.47349.arnaud.lb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] [PATCH] RecursiveTreeIterator implementation From: helly@php.net (Marcus Boerger) Hello Arnaud, Tuesday, July 22, 2008, 11:23:47 AM, you wrote: > Hello, >> > Care to look into the MultipleIterator next? >> > That's done, for 5_3 [1] and HEAD [2]. > And a test [3][4] covering mostly all the cases. > [1] http://arnaud.lb.s3.amazonaws.com/MultipleIterator_5_3.patch > [2] http://arnaud.lb.s3.amazonaws.com/MultipleIterator_HEAD.patch > [3] http://arnaud.lb.s3.amazonaws.com/multiple_iterator_001_5_3.phpt > [4] http://arnaud.lb.s3.amazonaws.com/multiple_iterator_001_HEAD.phpt Great work once more. I just moved the stuff all into spl_observer.c to avoid increasing the amount of stuff that gets exported in the headers. I also did a few minor tweaks and cleanups, nothing important though. - setFlags parses directly into &intern->flags which is a long for that reason - added !EG(exception) for the loops, though I have another patch that will make exception handling better I've also upgraded you, you've got php-src access now, use it wisely :-) Best regards, Marcus